From owner-svn-src-head@freebsd.org Thu Dec 21 00:20:03 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F531E8973F; Thu, 21 Dec 2017 00:20:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1944469697; Thu, 21 Dec 2017 00:20:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (astound-66-234-202-155.ca.astound.net [66.234.202.155]) by mail.baldwin.cx (Postfix) with ESMTPSA id 23F5610AF3A; Wed, 20 Dec 2017 19:20:02 -0500 (EST) From: John Baldwin To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326991 - in head/sys/fs: nfs nfsclient Date: Wed, 20 Dec 2017 15:11:39 -0800 Message-ID: <2816727.f1xFVHHEZ2@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <1513800442.29087.28.camel@freebsd.org> References: <201712191918.vBJJImA5072223@repo.freebsd.org> <1513800442.29087.28.camel@freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 20 Dec 2017 19:20:02 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 00:20:03 -0000 On Wednesday, December 20, 2017 01:07:22 PM Ian Lepore wrote: > On Tue, 2017-12-19 at 19:18 +0000, John Baldwin wrote: > > Author: jhb > > Date: Tue Dec 19 19:18:48 2017 > > New Revision: 326991 > > URL: https://svnweb.freebsd.org/changeset/base/326991 > > > > Log: > > Update NFS to handle larger link counts post ino64. > > > [...] > > Modified: head/sys/fs/nfsclient/nfs_clvnops.c > > ============================================================================== > > --- head/sys/fs/nfsclient/nfs_clvnops.c Tue Dec 19 19:14:01 2017 (r326990) > > +++ head/sys/fs/nfsclient/nfs_clvnops.c Tue Dec 19 19:18:48 2017 (r326991) > > @@ -3450,7 +3450,7 @@ nfs_pathconf(struct vop_pathconf_args *ap) > > * For NFSv2 (or NFSv3 when not one of the above 4 a_names), > > * just fake them. > > */ > > - pc.pc_linkmax = LINK_MAX; > > + pc.pc_linkmax = NFS_LINK_MAX; > > pc.pc_namemax = NFS_MAXNAMLEN; > > pc.pc_notrunc = 1; > > pc.pc_chownrestricted = 1; > > @@ -3460,7 +3460,7 @@ nfs_pathconf(struct vop_pathconf_args *ap) > > } > > switch (ap->a_name) { > > case _PC_LINK_MAX: > > - *ap->a_retval = pc.pc_linkmax; > > + *ap->a_retval = MIN(LONG_MAX, pc.pc_linkmax); > > I just noticed a build error on powerpc LINT and LINT64 kernels on this > line: > > /b/staging/freebsd/head/src/sys/fs/nfsclient/nfs_clvnops.c:3464: > warning: comparison is always false due to limited range of data type Ugh, ok. I'll do a full tinderbox and clean up any fallout. I had done one on an earlier version, but not the latest. :-/ Thanks. -- John Baldwin