From owner-svn-src-all@freebsd.org Mon Sep 19 21:23:55 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 398C1BE1DBA; Mon, 19 Sep 2016 21:23:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 11D61EA8; Mon, 19 Sep 2016 21:23:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id q2so5085264pfj.0; Mon, 19 Sep 2016 14:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CV8klox9EdnwM0kga9maFsMoKyYOgTQEBTe4TWqe9Qw=; b=gnpFAlYBNPTwaC7TBovmPB+UeBuJk/fXlw0Jb9Zarcc2yTJLt3T0qlnCLe2cwwtTrB aqYUvm/Q4RvqzWRk6DypLARQZgQfMxvptDmpJAVebQ7/eQzJAwg4jYPrIpecXQDqZmVu 1DwroVRjtACoWTPck2t7n24V0/pXJx5sZlq2Hr1+C9Q8Ffrzcr4siF7BRHLml+Ae8gWs 2ZKdaKm9/sqgSN3t1PRG4Bcj/hm3eifzVtJVzvfVNAmKwOOGlkHgu9rFdoUeIwZdTEhj hJJ04i9c2YYqQQqIP9R16pl/lTxG12BeIUy3mv5r64NIi+O0FRK/aDl8gvUoVmDyOcrO WkCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CV8klox9EdnwM0kga9maFsMoKyYOgTQEBTe4TWqe9Qw=; b=nDZcNsSkA5hJB5Oy6Z51cKf+exEcMEzI0KpyeepZFe3OZNZCBYHWirApRzrm3EvUD/ 0sdhsbNu97S+A2/bwnYbRZAT1I1y6rDmFhDvSVwknYFYW0paI5lEXLPqFMDMXjOhmMZr IgmJWt382V7kZX7BPD70OACsEF1vBj0LonUsyPEa/FOdhPN44wxNczwHp/+0eBDYLutM s4QkxREd0H0sungUKiLs3TcLbMuUR0yIYJg8bg7PO5pw0w6r3pkIDMTsi0XtP+ZVeUgk 8rb+SUXL8uxPUYcsf6aK+zhLM8KKh16fVubXfV62gyvWxU+WZF0GXCH9DT1lVwFhSxXR c9+w== X-Gm-Message-State: AE9vXwOwzzp1kGkIqfsz378Ph5YqbBNXv8bhfVEnEQGAxt29Fe4RKTDZ+0DnvW9o5B9r4A== X-Received: by 10.98.2.215 with SMTP id 206mr1116773pfc.89.1474320234463; Mon, 19 Sep 2016 14:23:54 -0700 (PDT) Received: from fuji-wireless.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id w69sm26824214pfd.28.2016.09.19.14.23.53 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Sep 2016 14:23:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r305998 - in head/usr.bin: cmp indent tr From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <8333248.dV1m5xp1ki@ralph.baldwin.cx> Date: Mon, 19 Sep 2016 14:23:53 -0700 Cc: "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7087F928-F8AB-499F-8D73-92B29FB20494@gmail.com> References: <201609192043.u8JKh3jv040006@repo.freebsd.org> <8333248.dV1m5xp1ki@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 21:23:55 -0000 > On Sep 19, 2016, at 2:22 PM, John Baldwin wrote: >=20 > On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: >>=20 >>> On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer = wrote: >>>=20 >>> Author: cem >>> Date: Mon Sep 19 20:43:03 2016 >>> New Revision: 305998 >>> URL: https://svnweb.freebsd.org/changeset/base/305998 >>>=20 >>> Log: >>> Move sys/capsicum.h includes after types.h or param.h >>>=20 >>> This is not actually documented or even implied in style(9). Make = the change >>> to match convention. Someone should document this convention in = style(9). >>>=20 >>> Reported by: jhb >>> Sponsored by: EMC Dell Isilon >>=20 >> Uh=E2=80=A6 yes it clearly states it in style(9). =46rom = https://www.freebsd.org/cgi/man.cgi?query=3Dstyle&sektion=3D9 : >> Kernel include files (i.e. sys/*.h) come first; normally, include >> OR , but not both. = includes >> , and it is okay to depend on that. >=20 > It doesn't actually say that types.h/param.h has to come before other = sys/*.h > headers though. Normally sys/foo.h requires sys/types.h to compile = hence the > rule, but sys/capsicum.h gets around this by a nested include of = sys/param.h > (which is itself probably dubious). >=20 > I do think we should explicitly add a note to style.9 though to say = that > types.h|param.h comes first. Yeah=E2=80=A6 I just reread it and I noticed that it=E2=80=99s not 100% = explicit. Thanks, -Ngie=