From owner-freebsd-hackers  Fri Jan 10 19:08:09 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id TAA22408
          for hackers-outgoing; Fri, 10 Jan 1997 19:08:09 -0800 (PST)
Received: from labs.usn.blaze.net.au (labs.usn.blaze.net.au [203.17.53.30])
          by freefall.freebsd.org (8.8.4/8.8.4) with ESMTP id TAA22403
          for <hackers@FreeBSD.org>; Fri, 10 Jan 1997 19:08:03 -0800 (PST)
Received: (from davidn@localhost)
          by labs.usn.blaze.net.au (8.8.4/8.8.4)
	  id OAA03332; Sat, 11 Jan 1997 14:07:37 +1100 (EST)
Message-ID: <Mutt.19970111140736.davidn@labs.blaze.net.au>
Date: Sat, 11 Jan 1997 14:07:36 +1100
From: davidn@unique.usn.blaze.net.au (David Nugent)
To: charnier@xp11.frmug.org ("Philippe Charnier")
Cc: hackers@FreeBSD.org
Subject: Re: unused variable in su
References: <199701110142.CAA28453@xp11.frmug.org>
X-Mailer: Mutt 0.56
Mime-Version: 1.0
In-Reply-To: <199701110142.CAA28453@xp11.frmug.org>; from "Philippe Charnier" on Jan 11, 1997 02:42:11 +0100
Sender: owner-hackers@FreeBSD.org
X-Loop: FreeBSD.org
Precedence: bulk

"Philippe Charnier" writes:
> In /usr/src/usr.bin/su/su.c, I get:
> line 101: char shellbuf[MAXPATHLEN];
> line 171: shell = strcpy(shellbuf,  pwd->pw_shell);
> 
> Shellbuf is not referenced elsewhere, is there any reason not to
> remove shellbuf (and adjust line 171), or is there a side effect I don't
> see?

Yes, there certainly is a side-effect. You can't leave it
pointing to pwd->pw_dir, since that points to an internal
libc buffer which may be overwritten by a call to any getpw*()
function.


Regards,

David Nugent - Unique Computing Pty Ltd - Melbourne, Australia
Voice +61-3-9791-9547  Data/BBS +61-3-9792-3507  3:632/348@fidonet
davidn@freebsd.org davidn@blaze.net.au http://www.blaze.net.au/~davidn/