From owner-freebsd-fs@freebsd.org  Fri Apr  2 20:30:07 2021
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA0E55B0A4A;
 Fri,  2 Apr 2021 20:30:07 +0000 (UTC)
 (envelope-from dch@skunkwerks.at)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FBs9p6ycPz3rdc;
 Fri,  2 Apr 2021 20:30:06 +0000 (UTC)
 (envelope-from dch@skunkwerks.at)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id 53D6A5C0114;
 Fri,  2 Apr 2021 16:30:06 -0400 (EDT)
Received: from imap6 ([10.202.2.56])
 by compute2.internal (MEProxy); Fri, 02 Apr 2021 16:30:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skunkwerks.at;
 h=mime-version:message-id:in-reply-to:references:date:from:to
 :cc:subject:content-type; s=fm2; bh=2lFNeKsouQYMV4kji1MzlmYOI4iS
 /wbtKEWcHO9cL98=; b=LjlKuosRhRm/FZ8y3t8CA3iWlpRHJMCJKl9MnzvaExRJ
 7e+/STzuCYAlZ+BtbYSQlw2bbbQmUMykJ94+XwdgWPVJAM6ynACE9bcJyfJzV6Uo
 Pd4UsAVsf4NXUGNjVsmrFPY7NN/EKAyBsa4e0AqEC26nubiWf6EjeWUdAmrF9iE6
 OI59YCi5U3nA/wvw73m1xxsuWTU/y7vzDtXOolclGW3T0VkVkX889+ARkVERRCM3
 xuSLKnkkVB9flCoQPMnnf2HKGj+8pqimuAxz7syeQUxopak2keWi3YniQeyjEHtR
 R59mIDH6DZV/NGcfKOJ+OYXZyY1f4tBXxTiVaJLXAA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2lFNeK
 souQYMV4kji1MzlmYOI4iS/wbtKEWcHO9cL98=; b=pFWw6N+rwCPM5BXj78c+xj
 BLIP/FeZ1AOhSmDUUmNbIfYM1TYFGom3v5bWhJU4ef/+NZEPfKbRtDe02jznn/lO
 8/SE7yW5agCPNywSKaPESdGT+vpK6r2Ol3tIgfvcYQS/gOn8N4BEMN8Gv0PLXRUa
 tR5S15F+ZgjxlrXiohOjMbFT0AcQsHEt80mMXzlTyHHNANKPN0OVFQ+kV8b+2guT
 aE3wH3REjK3ms+EUWmgNQ2Rp9yE7NReZXsyhhVcPvyVIApwIp4tSXVteotltbtBJ
 /17qJf/qEfWE51mZgolJ3PKe1/m5tuMQwusjFWZs7hWyGl7JLONnyFK1a+jpa+UQ
 ==
X-ME-Sender: <xms:zX5nYATRzRpZUOcOddgJdHRPJszdjX7_MUJKIFPErdW6OdJbMQFvxQ>
 <xme:zX5nYNyyEcPBpB65kCPUo8NShVLil4lBzUWqddDWXCao7jKxr_xlBwn6giy6CiMmq
 rz8q5VX0U5xcxDPNg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeiiedgudegkecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesth
 dtredtreertdenucfhrhhomhepfdffrghvvgcuvehothhtlhgvhhhusggvrhdfuceouggt
 hhesshhkuhhnkhifvghrkhhsrdgrtheqnecuggftrfgrthhtvghrnhepffffueefhfethe
 ehueduieduteefhffhkedufeejgfeghedvleffleelheekvdelnecuffhomhgrihhnpehh
 rggtkhhmugdrihhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepuggthhesshhkuhhnkhifvghrkhhsrdgrth
X-ME-Proxy: <xmx:zX5nYN0na5fIdkbWst9RrvheY2HidFj5stlck9jr_OOYKmri8f8YkA>
 <xmx:zX5nYEDzD2mOqGJuMpuFxjYY5IHfkobxalZHfsa-eJdGJ4TgmnmhBA>
 <xmx:zX5nYJjWmQtKet5uNe0bA-_s0DgEvq5GZVzEVIglSdv_wjVl-oxiEQ>
 <xmx:zn5nYJYmunbT8SG7RpGR0pKOZerIyAgSK_iJ-s-T34AYJvnO_1-ypA>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
 id 5E0292405E9; Fri,  2 Apr 2021 16:30:05 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249
Mime-Version: 1.0
Message-Id: <3c00c109-ed5a-496c-9339-22b3dc31747a@www.fastmail.com>
In-Reply-To: <YGQ6IyE6B31a6EV0@weirdfishes>
References: <YFhuxr0qRzchA7x8@weirdfishes> <YF8eL0dmSh6H8HX2@ceres.zyxst.net>
 <YF9YE282kOWN7ubr@weirdfishes> <YGMq6i+UIhNANHXW@weirdfishes>
 <YGQ6IyE6B31a6EV0@weirdfishes>
Date: Fri, 02 Apr 2021 20:29:43 +0000
From: "Dave Cottlehuber" <dch@skunkwerks.at>
To: "Mathieu Chouquet-Stringer" <me+freebsd@mathieu.digital>,
 freebsd-fs <freebsd-fs@freebsd.org>,
 freebsd-current <freebsd-current@freebsd.org>
Cc: bryanv@freebsd.org
Subject: Re: Scrub incredibly slow with 13.0-RC3 (as well as RC1 & 2)
Content-Type: text/plain
X-Rspamd-Queue-Id: 4FBs9p6ycPz3rdc
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org;
 dkim=pass header.d=skunkwerks.at header.s=fm2 header.b=LjlKuosR;
 dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pFWw6N+r;
 dmarc=none;
 spf=pass (mx1.freebsd.org: domain of dch@skunkwerks.at designates 66.111.4.25
 as permitted sender) smtp.mailfrom=dch@skunkwerks.at
X-Spamd-Result: default: False [-2.59 / 15.00]; XM_UA_NO_VERSION(0.01)[];
 TO_DN_SOME(0.00)[]; MV_CASE(0.50)[];
 R_SPF_ALLOW(-0.20)[+ip4:66.111.4.25];
 RWL_MAILSPIKE_GOOD(0.00)[66.111.4.25:from];
 RCVD_COUNT_THREE(0.00)[4];
 DKIM_TRACE(0.00)[skunkwerks.at:+,messagingengine.com:+];
 NEURAL_HAM_SHORT(-1.00)[-1.000];
 RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.25:from];
 RCVD_TLS_LAST(0.00)[];
 RBL_DBL_DONT_QUERY_IPS(0.00)[66.111.4.25:from];
 FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+];
 ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US];
 ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000];
 R_DKIM_ALLOW(-0.20)[skunkwerks.at:s=fm2,messagingengine.com:s=fm2];
 FREEFALL_USER(0.00)[dch]; FROM_HAS_DN(0.00)[];
 RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000];
 TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[text/plain];
 DMARC_NA(0.00)[skunkwerks.at];
 SPAMHAUS_ZRD(0.00)[66.111.4.25:from:127.0.2.255];
 TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_WWW(0.50)[];
 MAILMAN_DEST(0.00)[freebsd-current,freebsd-fs]
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2021 20:30:08 -0000

On Wed, 31 Mar 2021, at 09:00, Mathieu Chouquet-Stringer wrote:
> On Tue, Mar 30, 2021 at 03:43:06PM +0200, Mathieu Chouquet-Stringer wrote:
> > 	Hello,
> > 
> > TL;DR: we need kvmclock support in FreeBSD
> 
>   scan: scrub repaired 0B in 12:33:11 with 0 errors on Wed Mar 31 03:33:14 2021
> 
> It's almost twice as fast with kvmclock support...

Does the issue also go away if you use `TSC-slow` ?

I investigated exactly this issue yesterday[1],  and it's great to see Bryan's patch
resurrected, I will try it here and report back too.

[1]: https://hackmd.io/HhYlbsDJTpCWHSwlrwrY_w

A+
Dave