From owner-freebsd-current@FreeBSD.ORG  Thu Feb  3 09:58:36 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0D10C16A4CE
	for <current@freebsd.org>; Thu,  3 Feb 2005 09:58:36 +0000 (GMT)
Received: from mailout10.sul.t-online.com (mailout10.sul.t-online.com
	[194.25.134.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ACF4643D31
	for <current@freebsd.org>; Thu,  3 Feb 2005 09:58:35 +0000 (GMT)
	(envelope-from Alexander@Leidinger.net)
Received: from fwd00.aul.t-online.de 
	by mailout10.sul.t-online.com with smtp 
	id 1Cwdkw-0005xb-03; Thu, 03 Feb 2005 10:58:34 +0100
Received: from Andro-Beta.Leidinger.net
	(VaxJHqZU8eVzz6imhIfcNmR+uqtD6nWnTYVckIO+t5eXbysuwt68U0@[84.128.192.121]) by
	fmrl00.sul.t-online.com
	with esmtp id 1Cwdkj-07BkHI0; Thu, 3 Feb 2005 10:58:21 +0100
Received: from localhost (localhost [127.0.0.1])j139w4I2036893;
	Thu, 3 Feb 2005 10:58:05 +0100 (CET)
	(envelope-from Alexander@Leidinger.net)
Received: from 141.113.101.32 ([141.113.101.32]) by netchild.homeip.net
	(Horde) with HTTP for <Alexander@Leidinger.net>;
	Thu,  3 Feb 2005 10:58:03	+0100
Message-ID: <20050203105803.31hpqdb7y80gwgkc@netchild.homeip.net>
X-Priority: 3 (Normal)
Date: Thu,  3 Feb 2005 10:58:03 +0100
From: Alexander Leidinger <Alexander@Leidinger.net>
To: Roman Kurakin <rik@cronyx.ru>
References: <20050129161022.0de822fe@Magellan.Leidinger.net>
	<42013BC8.5040204@cronyx.ru>
In-Reply-To: <42013BC8.5040204@cronyx.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-15;
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.0.1) / FreeBSD-4.11
X-ID: VaxJHqZU8eVzz6imhIfcNmR+uqtD6nWnTYVckIO+t5eXbysuwt68U0@t-dialin.net
X-TOI-MSGID: 897fc2d2-da0c-4094-9c36-2d77320c0454
cc: current@freebsd.org
Subject: Re: We have a lot of duplicated code in the kernel
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2005 09:58:36 -0000

Roman Kurakin <rik@cronyx.ru> wrote:

>> I've filtered the list for some false positives (twa_fwimg, trlld?m,
>> if_patm_rtables), if someone else notices some more files please tell me
>> about them and I add them to the filter.
>>
> For example if_ct.c and if_cp.c. They have to have the same code since
> they written by the same authors, and both devices have almost the same
> architecture. If I remove or would use the same prefix for DDK of both
> adapters, I am sure, code would have more than 50% of the same code. ;-)

And we can't put the common code into another file which either gets included
(in case of macros), or linked (in case of functions) to the files in
question?

Bye,
Alexander.

-- 
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID = 72077137
Your object is to save the world,
while still leading a pleasant life.