From nobody Tue Feb 10 01:11:27 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f93Rx3kc3z6R6m3; Tue, 10 Feb 2026 01:11:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4f93Rw60sKz4PBw; Tue, 10 Feb 2026 01:11:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 61A1BRP3062960; Tue, 10 Feb 2026 03:11:30 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 61A1BRP3062960 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 61A1BRfp062959; Tue, 10 Feb 2026 03:11:27 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 10 Feb 2026 03:11:27 +0200 From: Konstantin Belousov To: "Bjoern A. Zeeb" Cc: Brooks Davis , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ad639400dc9f - main - sys/event.h: use freebsd32_uint64_t for kevent32 64bit members Message-ID: References: <698a3052.36544.6d7c1a7c@gitrepo.freebsd.org> <0qrpp6r-1374-7r1s-8o3o-9280q483q549@mnoonqbm.arg> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0qrpp6r-1374-7r1s-8o3o-9280q483q549@mnoonqbm.arg> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4f93Rw60sKz4PBw X-Spamd-Bar: ---- On Tue, Feb 10, 2026 at 12:42:24AM +0000, Bjoern A. Zeeb wrote: > On Mon, 9 Feb 2026, Konstantin Belousov wrote: > > Hi, > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=ad639400dc9f1c5aec470996473bb54edc113dba > > > > commit ad639400dc9f1c5aec470996473bb54edc113dba > > Author: Konstantin Belousov > > AuthorDate: 2026-02-05 19:22:44 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2026-02-09 18:57:19 +0000 > > > > sys/event.h: use freebsd32_uint64_t for kevent32 64bit members > > > > Reviewed by: brooks > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Differential revision: https://reviews.freebsd.org/D55135 > > It seems that this commit breaks drm-kmod radeon drivers at least. > > I assume given the abi_compat.h now gets exposed via event.h into > LinuxKPI and "CP2" etc. are just very generic names. I already created https://reviews.freebsd.org/D55202 > > > 26 In file included from /home/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/radeon/ci_dpm.c:31: > 27 /home/bz/local_modules_dir/drm-kmod/drivers/gpu/drm/radeon/cikd.h:852:10: error: 'CP2' macro redefined [-Werror,-Wmacro-redefined] > 28 852 | #define CP2 (1 << 2) > 29 | ^ > 30 /home/bz/git/FreeBSD/freebsd-src/sys/sys/abi_compat.h:73:9: note: previous definition is here > 31 73 | #define CP2(src, dst, sfld, dfld) do { \ > 32 | ^ > 33 1 error generated. > > > > --- > > sys/compat/freebsd32/freebsd32_misc.c | 38 ++++++----------------------------- > > sys/sys/event.h | 6 ++++-- > > usr.bin/kdump/kdump.c | 6 +----- > > 3 files changed, 11 insertions(+), 39 deletions(-) > > > ... > ... > ... > > diff --git a/sys/sys/event.h b/sys/sys/event.h > > index ebbcdb703183..0ba8e4796208 100644 > > --- a/sys/sys/event.h > > +++ b/sys/sys/event.h > > @@ -104,6 +104,8 @@ struct freebsd11_kevent { > > #endif > > > > #if defined(_WANT_KEVENT32) || defined(_KERNEL) > > +#include > > + > > struct kevent32 { > > __uint32_t ident; /* identifier for this event */ > > short filter; /* filter for event */ > ... > > -- > Bjoern A. Zeeb r15:7