From owner-freebsd-python@freebsd.org Fri Nov 15 04:10:31 2019 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E3141BBCFD for ; Fri, 15 Nov 2019 04:10:31 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47DlJ70MZ5z4TRS for ; Fri, 15 Nov 2019 04:10:31 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 0A4261BBCFA; Fri, 15 Nov 2019 04:10:31 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 090911BBCF9; Fri, 15 Nov 2019 04:10:31 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47DlJ52CgDz4TPX; Fri, 15 Nov 2019 04:10:28 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf1-x432.google.com with SMTP id r4so5745658pfl.7; Thu, 14 Nov 2019 20:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gYCvcwr91F38XSHbrivCzHEgyp+I9eRoA+M5vSCzb60=; b=oEvKmFcF9nN3LMpSnRFvlaz3ZPc8IljaCerpJNpXroua4PtIj4pZw9aFFOvB8Mltrd AlmfpoUjVA/nPtmJW1P2w3idM4bGr8CON5SE2JslZq96eExcLeROTHEOzDk38+xo50Dg P1qGdJcre/NI8shLcQ9A4p1MYMPtJA6r6AC+tNWeK9UpCoC83yK4I3iYRonVjLCoEUyi aUSGuC7ZfG1SmoHXzkz9azFJX9MmrgYxORyuL29pU9q02m3BazH7/cZSoIxBa99OFcWA J3U+Pc3kUvMvC+iYCntqaFPhgt/nEB8biv4wpfEEsJEljSdyojWmTRlKJRwi064gwCsF 3IeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gYCvcwr91F38XSHbrivCzHEgyp+I9eRoA+M5vSCzb60=; b=JczVTGE/X7zv/wEWjko+SOjgB8tWjP/29nxPPx47cPE05LHlw+xbBGiwli3LZ626sy w+paad4OGcjTqk8/8S1vwXVbRKOLReEHjsb/kYVnZs2a2hepZ931VpJ9KT+xa+nZRqE9 Kxq81LSe4d6j7Dbsq0Lqitl42duWKfX9cdrIRjLZJZLgq5v59gXHqqioluBZyR7gv4Fm 0+WOQ9jG5dLdPexckK1TzatC/G8+MiEE/rBE0xUiiuMR/kuEOp/6TDjgISWsJW3QiYLp VZNCbHad8MIj4VpVXTo6I9icatXhSefozbvFTGDhmH/IZYUjRoO7S267ZPxvNxgejkNK fQHw== X-Gm-Message-State: APjAAAXmRkdgw1CPDoYR4rkbZ5bOltwGL9rE70DYByRQ1F/twzHWR/wD 5dRLce2iicWotpnfVMdOI1FPUYmy X-Google-Smtp-Source: APXvYqwZCUKdfBdkW7ztOJtpz4NFuQgbcpl1fvxNISeY6U+jUzEW9K6daOcGhIK049HK6uyNtfykWw== X-Received: by 2002:a63:2225:: with SMTP id i37mr4730920pgi.62.1573791026513; Thu, 14 Nov 2019 20:10:26 -0800 (PST) Received: from [192.168.1.110] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id z62sm10293751pfz.135.2019.11.14.20.10.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 20:10:25 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r517602 - head/devel/py-mock To: Jan Beich Cc: Enji Cooper , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python References: <201911141711.xAEHBwBO077712@repo.freebsd.org> <6f252ffe-9e8d-3bb7-fe48-baccda10012d@FreeBSD.org> From: Kubilay Kocak Message-ID: <5b6c8282-cbb4-d852-8260-95d7896c91e4@FreeBSD.org> Date: Fri, 15 Nov 2019 15:10:21 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Thunderbird/71.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47DlJ52CgDz4TPX X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=oEvKmFcF; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::432 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-4.67 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; IP_SCORE(-2.47)[ip: (-7.99), ipnet: 2607:f8b0::/32(-2.32), asn: 15169(-1.99), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_IN_DNSWL_NONE(0.00)[2.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Nov 2019 04:10:31 -0000 On 15/11/2019 2:27 pm, Jan Beich wrote: > Kubilay Kocak writes: > >> The canonical pytest invocation is: >> >> cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts= > > For a canonical it is uncommon. Besides, you've made mistakes: > - No braces around `cd` compared to what Porter's Handbook recommends > - No TEST_ENV in case tests need TZ=UTC, LANG=en_US.UTF-8, etc. > I wasn't being perfectly compliant to focus on the pytest specific invocation elements. Of course, framework mechanisms should be used where appropriate and it is recommended to do so.