From owner-cvs-all Mon Oct 28 19: 2:36 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7FFDC37B401; Mon, 28 Oct 2002 19:02:35 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 057C643E88; Mon, 28 Oct 2002 19:02:35 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id g9T32XnQ036983; Mon, 28 Oct 2002 19:02:33 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.5/Submit) id g9T31IF2036977; Mon, 28 Oct 2002 19:01:18 -0800 (PST) Date: Mon, 28 Oct 2002 19:01:18 -0800 From: "David O'Brien" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch common.c Message-ID: <20021029030118.GA36927@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200210271720.g9RHKnUS015686@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200210271720.g9RHKnUS015686@repoman.freebsd.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Oct 27, 2002 at 09:20:49AM -0800, Dag-Erling Smorgrav wrote: > des 2002/10/27 09:20:49 PST > > Modified files: > lib/libfetch common.c > Log: > Slight amendment to rev 1.34: instead of considering any short read an > error, only report an error if no data was read at all (unless len was > 0 to start with). Otherwise, the final read of practically any transfer > will end in a fatal error. > > Revision Changes Path > 1.37 +8 -6 src/lib/libfetch/common.c Please back this out, it core dumps for me: fetch -v ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-current/Latest/jive.tbz looking up proxy.mycompany.com connecting to proxy.mycompany.com:66 requesting ftp://ftp.freebsd.org:21/pub/FreeBSD/ports/i386/packages-current/Latest/jive.tbz fetch: jive.tbz: size of remote file is not known Receiving jive.tbz: 0 bytesBus error (core dumped) If I take common.c back to rev 1.36, this does not happen. (note this is with an up to date fetch(1) and libfetch(1), an Oct-8 kernel and Oct-16 libc.so.5) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message