From owner-freebsd-audit Thu Jul 4 4:49:52 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A94E37B400 for ; Thu, 4 Jul 2002 04:49:51 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B1D943E09 for ; Thu, 4 Jul 2002 04:49:50 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA10630; Thu, 4 Jul 2002 21:49:44 +1000 Date: Thu, 4 Jul 2002 21:55:45 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Mark Murray Cc: audit@FreeBSD.ORG Subject: Re: lib/csu cleanup #2 - review please (commit candidate) In-Reply-To: <200207041051.g64ApNii029382@grimreaper.grondar.org> Message-ID: <20020704215102.A21853-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 4 Jul 2002, Mark Murray wrote: > > > Because I could see no reason to clutter the file with unused > > > structure declarations, just so that unused arguments could be > > > instantiated. Call it a code cleanup. The code has been verified > > > to work in a make world. > > > > Hrmph. My review said that the i386 code should probably be changed > > to be more like the alpha code here, not the reverse. There are no > > varargs functions here. Declaring and implementing a non-varargs > > function as varargs gives machine-dependent breakage, e.g., passing > > the args in the wrong place on only some machines. > > Your review was Hard To Read(tm), and explained how things worked, > without really giving a particularly strong direction for how things > should proceed. Quoted: Sigh. I've already given more than enough expanations. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message