Date: Thu, 4 Jul 2002 21:55:45 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mark Murray <mark@grondar.za> Cc: audit@FreeBSD.ORG Subject: Re: lib/csu cleanup #2 - review please (commit candidate) Message-ID: <20020704215102.A21853-100000@gamplex.bde.org> In-Reply-To: <200207041051.g64ApNii029382@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 4 Jul 2002, Mark Murray wrote: > > > Because I could see no reason to clutter the file with unused > > > structure declarations, just so that unused arguments could be > > > instantiated. Call it a code cleanup. The code has been verified > > > to work in a make world. > > > > Hrmph. My review said that the i386 code should probably be changed > > to be more like the alpha code here, not the reverse. There are no > > varargs functions here. Declaring and implementing a non-varargs > > function as varargs gives machine-dependent breakage, e.g., passing > > the args in the wrong place on only some machines. > > Your review was Hard To Read(tm), and explained how things worked, > without really giving a particularly strong direction for how things > should proceed. Quoted: Sigh. I've already given more than enough expanations. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020704215102.A21853-100000>