From owner-svn-src-head@freebsd.org Tue Sep 22 20:51:35 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E41E3F67B5; Tue, 22 Sep 2020 20:51:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BwtlC1Jvjz4cPJ; Tue, 22 Sep 2020 20:51:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f43.google.com with SMTP id y2so19537764lfy.10; Tue, 22 Sep 2020 13:51:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wm8duuaB5Z5dXiBKkELAdzP+AGeKpdvIgulOlePA7xU=; b=joSmXyQ0qPgrjo/5JKu3q9CtonA0m4sH9nXFKF4maasHnkLdprSDmynp0jEz9OZbkK LgzZD05QArERdYKRZtZrsu5yVnTQXe4ABAwkCHUVgkACKzsl4omh0gU7ErLg1Xmxeylf zejSwcfBm5+cSVZAhaYE6Mvmk+giiTgPxLY2UwrjzPfUDePfKQEcU9x8dXBZOGf8r/5t ShZcrd22t5rMFt7rv0n8XKB6eajqKgXrZqcihWvXr82zukIykna3MYi8HVg50CGT5ga5 o2XUTT4T4Qwj0mtnWWdiEuiQ6NbQ1DYtuu1MxmH/3+FaIuAcSNzM5ZYdmVdll1lcXbI7 66qA== X-Gm-Message-State: AOAM5301HLgTjlC95s54UuWEXHoxihYxxfaVVSbWVc/do4lrXCGFBNGS ccpMbvxoFCTmMSvxMln1yze8/GvBdZBZxQ6NiYmFpOBO X-Google-Smtp-Source: ABdhPJzLA2DtRnw+4BOy3+7h7Uoi8M/46FFodetwNOV1zUWnCxGOodZJ/ldD4XQMTex93zSClp3hifIlTC3WP4Mb3lg= X-Received: by 2002:a19:8906:: with SMTP id l6mr2573519lfd.136.1600807892764; Tue, 22 Sep 2020 13:51:32 -0700 (PDT) MIME-Version: 1.0 References: <202009112049.08BKnavL032212@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Tue, 22 Sep 2020 14:51:20 -0600 Message-ID: Subject: Re: svn commit: r365643 - head/bin/cp To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4BwtlC1Jvjz4cPJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 20:51:35 -0000 On Tue, Sep 22, 2020 at 2:48 PM Kyle Evans wrote: > On Fri, Sep 11, 2020 at 3:49 PM Alan Somers wrote: > > > > Author: asomers > > Date: Fri Sep 11 20:49:36 2020 > > New Revision: 365643 > > URL: https://svnweb.freebsd.org/changeset/base/365643 > > > > Log: > > cp: fall back to read/write if copy_file_range fails > > > > Even though copy_file_range has a file-system agnostic version, it > still > > fails on devfs (perhaps because the file descriptor is non-seekable?) > In > > that case, fallback to old-fashioned read/write. Fixes > > "cp /dev/null /tmp/null" > > > > Hi, > > Any objection to adding a quick UPDATING entry for this? I'm seeing > occasional reports of this breakage as recent as today on IRC from > folks that were a little bit thrown off by this because it throws up > fairly far into the build and looks like a stand build regression > instead of a cp regression. > > Thanks, > > Kyle Evans > No objection. Can you suggest the proper wording?