From owner-freebsd-sysinstall@freebsd.org Mon Nov 28 14:44:02 2016 Return-Path: Delivered-To: freebsd-sysinstall@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16513C592CB for ; Mon, 28 Nov 2016 14:44:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 05A771E30 for ; Mon, 28 Nov 2016 14:44:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uASEi1Q4003204 for ; Mon, 28 Nov 2016 14:44:01 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-sysinstall@FreeBSD.org Subject: [Bug 202058] bsdinstall - Disable dialog(3) for distfetch/checksum/distextract targets Date: Mon, 28 Nov 2016 14:44:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ganael.laplanche@corp.ovh.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-sysinstall@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-sysinstall@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Sysinstall Work List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2016 14:44:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202058 --- Comment #11 from Ganael LAPLANCHE --- Hi Devin, Thanks for your answer. You're definitely right, tty availability should be detected at runtime. I have focused on C tools (i.e. distfetch and distextract). Find attached t= wo patches -one for each tool- implementing what has been written so far. A few things may still be addressed: - libdpv(3) is not built at all if dialog(3) is not built, anyway it can be used with DPV_DISPLAY_STDOUT which does not need dialog(3). Maybe HAVE_DIAL= OG stuff can be added there too to enable building libdpv(3) without dialog(3)= ? - output of distextract is not really sexy when using DPV_DISPLAY_STDOUT (anyway, "it works (TM)") - other code from bsdinstall still needs work : partedit (does that make se= nse ?) and scripts/ directory - we may still want to add nonInteractive stuff, because a few calls to dialog_msgbox(,,,,TRUE) remain interactive, just waiting for the user to acknowledge the msg box - finally, I have not added any option to the tools and rely on the 'noTty'= env variable only (to keep the original spirit of the tools) Best regards, Ganael. --=20 You are receiving this mail because: You are the assignee for the bug.=