From owner-freebsd-bugs@freebsd.org  Wed Dec  9 13:22:51 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C69679D551B
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed,  9 Dec 2015 13:22:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9F0B11C0D
 for <freebsd-bugs@FreeBSD.org>; Wed,  9 Dec 2015 13:22:51 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tB9DMpYf058964
 for <freebsd-bugs@FreeBSD.org>; Wed, 9 Dec 2015 13:22:51 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 205157] [patch] pw(8) does not accept 8-bit characters in a
 GECOS field
Date: Wed, 09 Dec 2015 13:22:51 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.2-RELEASE
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: orios814@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter attachments.created
Message-ID: <bug-205157-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Dec 2015 13:22:51 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205157

            Bug ID: 205157
           Summary: [patch] pw(8) does not accept 8-bit characters in a
                    GECOS field
           Product: Base System
           Version: 10.2-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Many People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: orios814@gmail.com
          Keywords: patch

Created attachment 164014
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=164014&action=edit
A patch to make pw(8) accept 8-bit characters in a GECOS field.

The command pw(8) does not accept 8-bit characters in a GECOS field, though
'pw_user.c' claims at line 1238 that 8-bit characters are intended to be
allowed in a GECOS field.

[How-To-Repeat] Try the following command on your shell.
# pw useradd foobar -c '<some 8-bit characters>'

[Reason] The function 'pw_checkname' in '/usr/src/usr.sbin/pw/pw_user.c' checks
if the input string does not have characters of 0x00--0x1F at line 1233 by the
following condition:
  *ch < ' '
However, the type of 'ch' was changed from 'u_char' to 'char' (Jul. 3, 2015),
which made the above condition match also characters 0x80--0xFF. So the
condition must be the following:
  (*ch >= 0 && *ch < ' ')

The attached patch for '/usr/src/usr.sbin/pw/pw_user.c' will fix this problem.

Thank you for reading!

-- 
You are receiving this mail because:
You are the assignee for the bug.