From owner-freebsd-net  Fri Sep 25 23:51:32 1998
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id XAA29311
          for freebsd-net-outgoing; Fri, 25 Sep 1998 23:51:32 -0700 (PDT)
          (envelope-from owner-freebsd-net@FreeBSD.ORG)
Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5])
          by hub.freebsd.org (8.8.8/8.8.8) with SMTP id XAA29304
          for <net@FreeBSD.org>; Fri, 25 Sep 1998 23:51:26 -0700 (PDT)
          (envelope-from luigi@labinfo.iet.unipi.it)
Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id HAA13908; Sat, 26 Sep 1998 07:02:57 +0200
From: Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Message-Id: <199809260502.HAA13908@labinfo.iet.unipi.it>
Subject: Re: Packet/traffic shapper ?
To: easmith@beatrice.rutgers.edu (Allen Smith)
Date: Sat, 26 Sep 1998 07:02:56 +0200 (MET DST)
Cc: ark@eltex.ru, kev@lab321.ru, mike@smith.net.au, net@FreeBSD.ORG
In-Reply-To: <9809260238.ZM15204@beatrice.rutgers.edu> from "Allen Smith" at Sep 26, 98 02:38:20 am
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> > To get the idea, the most difficult part is the ipfw code to pass
> > RED parameters to the kernel!
> 
> Nice... although given other capabilities that IpFilter has (including 
> ones that I've patched into it, such as making ICMP messages look like 
> they're coming from the supposed destination machine - allowing for
> what will look to other machines like a bridge, but is actually
> looking at higher-level information than just the MAC address), it'd
> be nicer if somebody adapted it and dummynet to work together.

you just look like the right "somebody" !
seriously, i think it would be a fairly easy task to adapt ipfilter
to work with dummynet, as it was for ipfw, and i will be happy to help
you if you want to work a little bit on the adaptation (the main
obstacle for me would be to learn and understand the ipfilter code, you
seem to know it somehow having patched it).

All i had to do to support dummynet in ipfw
was to add a new return code to the ipfw call so that i
could decide to pass accepted packets to a pipe.

Once you have done that, you just need to process the return code from

	(*fr_checkp)(...)

in the same exact way it is done for

	(*ip_fw_chk_ptr)(...)

e.g. in ip_input.c (look at the -stable code, since this is not in
-current yet).

Actually, if we manage to make the kernel interfaces for ipfw and
ipfilter the same (they seem to be already 99% compatible) the
integration will come for free.

So essentially, can you look at how hard would it be to add support for
multiple return codes to ipfilter ? Then when the dummynet code will be
in -current (hopefully soon) you will be able to use it.

	cheers
	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message