From owner-svn-src-head@FreeBSD.ORG Tue Feb 10 06:02:38 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9BB00BC; Tue, 10 Feb 2015 06:02:38 +0000 (UTC) Received: from smtp3.ore.mailhop.org (smtp3.ore.mailhop.org [54.149.88.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 79D32757; Tue, 10 Feb 2015 06:02:38 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by smtp3.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YL2yG-0001aI-7D; Tue, 10 Feb 2015 05:02:48 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t1A52kqx078246; Mon, 9 Feb 2015 22:02:46 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+MvtkUsfkbB4QM92a5uxkZ Message-ID: <1423544566.80968.9.camel@freebsd.org> Subject: Re: svn commit: r278494 - head/sys/kern From: Ian Lepore To: Rui Paulo Date: Mon, 09 Feb 2015 22:02:46 -0700 In-Reply-To: <7FCF7F90-C1B2-4C1C-8781-F89F8519D47E@me.com> References: <201502100434.t1A4YeLr052513@svn.freebsd.org> <7FCF7F90-C1B2-4C1C-8781-F89F8519D47E@me.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 06:02:38 -0000 On Mon, 2015-02-09 at 20:46 -0800, Rui Paulo wrote: > On Feb 9, 2015, at 20:34, Rui Paulo wrote: > > > > Author: rpaulo > > Date: Tue Feb 10 04:34:39 2015 > > New Revision: 278494 > > URL: https://svnweb.freebsd.org/changeset/base/278494 > > > > Log: > > Sanitise the coredump file names sent to devd. > > > > While there, add a sysctl to turn this feature off as requested by > > kib@. > > I wanted to get the sanitiser code in ASAP, but, as suggested by stas@ offline, we think devd should also provide an action mode that runs a command outside sh(1) and without using $PATH. > > -- > Rui Paulo > > > > > Or... we could consider restoring devd to its original relatively benign existance handling device-related events, and move handling of crash dumps into a separate daemon which can shoulder the burden of security for itself. At $work we listen to the devd re-distribute port to handle device events in our apps, and having an ever-growing flood of stuff that's got nothing to do with devices is going to have a negative impact on applications that do such things. -- Ian