From owner-svn-src-head@FreeBSD.ORG Tue Apr 21 18:21:21 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC7FA106566C; Tue, 21 Apr 2009 18:21:21 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 7718F8FC2B; Tue, 21 Apr 2009 18:21:21 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n3LIH2Ao050196; Tue, 21 Apr 2009 12:17:02 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 21 Apr 2009 12:18:05 -0600 (MDT) Message-Id: <20090421.121805.-1954387331.imp@bsdimp.com> To: stas@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20090421220138.f6e7b4d4.stas@FreeBSD.org> References: <200904201547.n3KFl6Z6050834@svn.freebsd.org> <20090421.092505.-1186699961.imp@bsdimp.com> <20090421220138.f6e7b4d4.stas@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191322 - in head/sys: arm/conf dev/iicbus X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 18:21:22 -0000 In message: <20090421220138.f6e7b4d4.stas@FreeBSD.org> Stanislav Sedov writes: : -----BEGIN PGP SIGNED MESSAGE----- : Hash: SHA1 : : On Tue, 21 Apr 2009 09:25:05 -0600 (MDT) : "M. Warner Losh" mentioned: : : > In message: <200904201547.n3KFl6Z6050834@svn.freebsd.org> : > Stanislav Sedov writes: : > : Author: stas : > : Date: Mon Apr 20 15:47:06 2009 : > : New Revision: 191322 : > : URL: http://svn.freebsd.org/changeset/base/191322 : > : : > : Log: : > : - Give a warning and start the oscillator if it was not previously : > : runned. : > : - Rename ds1672 -> rtc to follow the other drivers. : > : > This is a bad change. Please back it out. There are multiple : > different kinds of rtc clocks that can live on i2c. : > : : Why do you want to? We already have ds133x under the same name. In case : if there're multiple clocks in the same systems the first one will : have the name of rtc0, the second - rtc1 and so on. Because you'll want to support a range of boards that might have multiple different kinds of rtc i2c clocks. Calling them all i2c won't work because you can't probe the i2c bus in any meaningful way. the ds133x one, if it is named rtc, is wrong too. : Before the names of devices were ds16720, ds16721, which I looks : ugly. That's not a good enough reason to change it. That's a cosmetic issue that is much less important than the functional issue I raised above. Warner