From owner-freebsd-mips@FreeBSD.ORG Wed Aug 4 14:23:01 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A0CA1065670; Wed, 4 Aug 2010 14:23:01 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 844C38FC2A; Wed, 4 Aug 2010 14:23:00 +0000 (UTC) Received: by fxm13 with SMTP id 13so2531398fxm.13 for ; Wed, 04 Aug 2010 07:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=sJOVulrp7adjAqw1xU+22/RhTlz+aVTSNkhg8CXRWm8=; b=IgOx+HQzJjo08YlLkyaiRz5RzZnro9cel4fZu/HSqu2olo3zdwtJZ8dWNfbeiNTnVC g4FsHZta/L9mhz+3UirExB+SXJrsnaFDN6S3c7sMhDhMeSM7/imKS/eiRh9QiVEILCEd ZUXW36bQCnEh5ZbyEkJPy9QNQ0viIinH4L6BI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=F6SKzz1alwHq8QuuswpZZQVoE8Ot4f9a98kevSuQMnZQzPbhJ/DzljG6m+u7GEUW7S WZlJRNGngHUO2uZBB1JtxsCcFrP6Z+wTL32aA+Vg1JS3HyOlrwyfRM8CjCC4H5+UAwpO TbcI54pdbzd6T/ABIlHuS9/jD6v55/e6uzNu8= Received: by 10.223.122.198 with SMTP id m6mr9008381far.87.1280931779323; Wed, 04 Aug 2010 07:22:59 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id r5sm2986974faq.8.2010.08.04.07.22.57 (version=SSLv3 cipher=RC4-MD5); Wed, 04 Aug 2010 07:22:57 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C5977BC.1060104@FreeBSD.org> Date: Wed, 04 Aug 2010 17:22:52 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.24 (X11/20100402) MIME-Version: 1.0 To: Neel Natu References: <4C41A248.8090605@FreeBSD.org> <4C41B4CF.6080409@FreeBSD.org> <4C4205CC.6080700@FreeBSD.org> <4C4ED247.80701@FreeBSD.org> <4C555CF7.5080101@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Randall Stewart , freebsd-mips@freebsd.org, Neel Natu Subject: Re: [RFC] Event timers on MIPS X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 14:23:01 -0000 Neel Natu wrote: > Thanks for taking the time to review the patch. Here is the updated patch: > http://people.freebsd.org/~neel/tick_diff.txt Seems fine. > On Sun, Aug 1, 2010 at 4:39 AM, Alexander Motin wrote: >> "t_upper++;" there looks a bit strange, as it is not written back. The >> wrapping stuff won't work if this timer interrupts were not used. > > This part is intentional. > > I wanted only clock_intr() to update the cached values of > 'counter_upper' and 'counter_lower_last' and tick_ticker() to sample a > consistent snapshot of the tuple and then operate on it. > > I have added an XXX comment to describe the dependency. We can revisit > this if we change the default timer in mips. It's not about default timer, but about having any other timer. But if you wish so, it should be enough for now. -- Alexander Motin