Date: Tue, 16 May 2017 10:57:57 +0200 From: Rodrigo Osorio <rodrigo@osorio.me> To: Adam Weinberger <adamw@adamw.org>, Rodrigo Osorio <rodrigo@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r440978 - in head: devel devel/npm-amdefine devel/npm-clean-css devel/npm-clean-css/files devel/npm-commander devel/npm-commander/files devel/npm-graceful-readlink devel/npm-source-map ... Message-ID: <afe6f1eb-502a-3a12-4896-38bdfdbd4f65@osorio.me> In-Reply-To: <6F0B8538-C30A-42A4-A3C3-D0BA1FA8F6F4@adamw.org> References: <201705152205.v4FM5kIw055373@repo.freebsd.org> <6F0B8538-C30A-42A4-A3C3-D0BA1FA8F6F4@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/16/17 00:27, Adam Weinberger wrote: >> On 15 May, 2017, at 16:05, Rodrigo Osorio <rodrigo@FreeBSD.org> wrote: >> >> Author: rodrigo >> Date: Mon May 15 22:05:46 2017 >> New Revision: 440978 >> URL: https://svnweb.freebsd.org/changeset/ports/440978 >> >> Log: >> Add npm-less-plugin-clean-css a www/lesc tool pluggin and its dependencies >> >> www/npm-less-plugin-clean-css: Compresses the css output from less using clean-css >> ` devel/npm-clean-css: Fast and efficient CSS optimizer for node.js and the Web >> ` devel/npm-source-map: Parse and consume source maps >> | ` devel/npm-amdefine: Implementation of AMD's define() in Node >> ` devel/npm-commander: node.js command-line interfaces made easy >> ` devel/npm-graceful-readlink: Graceful fs.readlink > What do all these ports do that npm doesn't already do, especially given that this will cause breakage for everybody with any of these modules installed globally? > > # Adam > > Hi Adam, That's npm dependencies that need to be packages properly, I'll feel unsafe if the port relies on npm to download external sources from github during the packaging, without checking the integrity. Of course, this could be an issue for peoples who deploys npm packages on their own, but how can we handle this ? Maybe dep search path should be set manually if you install unpackaged npm tools ? I run a quick test, but apparently node uses in tree dependencies before global. Cheers -- rodrigo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?afe6f1eb-502a-3a12-4896-38bdfdbd4f65>