Date: Wed, 30 Apr 2008 19:36:45 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: grehan@freebsd.org Cc: freebsd-ppc@freebsd.org Subject: Re: BMAC Ethernet Driver Message-ID: <4818AE2D.2070201@semihalf.com> In-Reply-To: <4818A8B0.6020805@freebsd.org> References: <47E06B23.7060400@uchicago.edu> <20080325023040.ab0daa19.stas@FreeBSD.org> <47E8527B.2050002@uchicago.edu> <47F39EF4.8040800@uchicago.edu> <C83E8810-B68B-49B5-A7F4-8B72A4FFFFDA@mac.com> <47F3D2BC.7060001@uchicago.edu> <47F422A0.9080907@uchicago.edu> <CB59240D-E385-4D4C-9372-E9D418502F61@mac.com> <EB224547-BCC9-4467-98E5-1D8EC0352349@mac.com> <Pine.GSO.4.62.0804022152590.20081@harper.uchicago.edu> <C1AB89FF-C466-46B0-BA83-2AD2989E73F9@mac.com> <47F4E007.90802@uchicago.edu> <3B02E59E-5399-40B6-9747-2F49200FD708@mac.com> <47F59C13.9030705@uchicago.edu> <9A74257B-DD5E-4C7E-B1FE-F42D55D1BB41@mac.com> <48152F8F.7030601@uchicago.edu> <61AA447E-2D56-4305-AE25-C4209D1FA540@mac.com> <4818A765.50507@uchicago.edu> <4818A8B0.6020805@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Grehan wrote: >> I'm trying to figure out where to put the files. There are a lot of >> sparc64 (and i386) specific drivers in /sys/dev, but SoC peripherals >> tend to end up in an arch-specific location. For powermac hardware, we >> seem to have a mix (UART driver in /sys/dev, built-in ATA in >> powermac). Unless someone tells me otherwise, I will put the if_bm* >> stuff in powermac. > > I was mistaken in putting the ATA stuff (and others) into powermac/. It > makes it a tad more difficult to build modules, manpages etc. There's > plenty of precedent for single-arch drivers going into dev/. It also > makes it easier for folk to find things when they are doing changes that > sweep the tree, such as modifying a field in the ifnet struct. > > I vote for it to go into dev/. Yes, I also think we should keep the drivers under sys/dev/, unless really required otherwise. Even for the SoCs it's common to see their integrated peripherals being shared between different models or even families, which could be based on totally different CPU cores (or even architecture). On a more general note: the sys/dev/ has long been a simple flat container with everything in it, which is slowly making things more difficult with all new architectures and peripherals coming into the tree. Has anyone contemplated some reorganization of device drivers directory in a more hierarchical fashion, so we could better manage similar classes of devices from various vendors, have a bit more uniform naming scheme and so on? Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4818AE2D.2070201>