From owner-svn-src-all@freebsd.org Mon Nov 30 16:03:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 07CE14A1A6E for ; Mon, 30 Nov 2020 16:03:03 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cl94Q597Gz3qpj for ; Mon, 30 Nov 2020 16:03:02 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1606752180; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=CeA08vJXumKtk7NwfY02+7k/bayFVL6851N5qM7efVAK9szekVbHObFzTkdxQ529vjVdQrAcSGzhf +SovkUBpEcmPTObbUU4Q49IXHLesLgykzPz2NBlGwaON779MQuiY+OmFAIrPaqs9zHuem0qn16RBjY kB9qOthVm5VAPYxQWPsXy3isQrKw2sG1Awxhr7092VgYI9y7pF3g6d+BqqN6ddaeKttGyzu1e6Jfct KO7FQtF/OeFUVP7awKnw2PyLtTI1DhRATWiv/izXC5+YCgeMtxbTExkOrc0uyDClZ6RjrC6wBjAEU2 eaQut7EwrvmP/eWaX2kzqUoDOgjnqxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=X2pZnyVNDYsDxoSSmcLnkxRF6SsiJMhpzJnWlS5MRBI=; b=eTnkY1AqsOCQ2tIOfsLK5aCJJ8qUdYpFe8IyXHJhCmoqnSEgWo0oSSJcJQaifNU7EFPssQxLuvShU J+V2yYyB0KelKH32S4v7uxV+fmGcDJfRhyntWo9fMAsH94naioLJmnpe8USKkhIyHur/jFLp7G2CZG KbWuDLrzI0QfgnQ3fzXmW4lvs2/PD42wM2itxwgqLWhWmfYlrptiqFPQE3S7RGARNS3U1/KPjCdcbx QS8GGt5A7UvuBhmnZJ3uLcoBDkU6f+H5zg5bYw6fNCyLKqDhLJEtobxmedZhf+DQbFV4LMpdJTtfjh 4QwJcjdhZi1HUpi1+kuzeO7ILNILpEA== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=X2pZnyVNDYsDxoSSmcLnkxRF6SsiJMhpzJnWlS5MRBI=; b=Ou5XW+yuV7EDyivckYH9w4bjrbCGTruf0aJFtn2dIu60Q3Zk9QgQvzivhO6vjYul4al+L5R8pAAvS SmbSk/zQTQ1Inp3qYX/bxaCMc2+AFMR8I5SGcRuLjSUXuIyZptLestp57s5/C0BTQtscSrHxsqJcTC atdD1CnwqpaREsFw5TgvtqiQBNL4g2QKwnXXQcl1G8dXoFloTfg0XbUn/qoELFQQrlmkXwSdPIPBy0 gF2NhJFB0c2J28tATqwPpqcVZGelDLz25lfzVyjZ5FeTNE3KUtu/PAm7nXItLAHv/Ku6rtNBoaKAzG L+Lo69ZQ4Dk/6oHa+M3fONagyk7dPhg== X-MHO-RoutePath: aGlwcGll X-MHO-User: 83bc4192-3325-11eb-9e13-df46ed8f892f X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 83bc4192-3325-11eb-9e13-df46ed8f892f; Mon, 30 Nov 2020 16:02:59 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 0AUG2vkS091048; Mon, 30 Nov 2020 09:02:57 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <5bd6eb969c3a198246ab915257375b02c7b14e0c.camel@freebsd.org> Subject: Re: svn commit: r368187 - head/sys/dev/nvme From: Ian Lepore To: Michal Meloun , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 30 Nov 2020 09:02:57 -0700 In-Reply-To: <202011301451.0AUEpn9w002536@repo.freebsd.org> References: <202011301451.0AUEpn9w002536@repo.freebsd.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Cl94Q597Gz3qpj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 16:03:03 -0000 On Mon, 2020-11-30 at 14:51 +0000, Michal Meloun wrote: > Author: mmel > Date: Mon Nov 30 14:51:48 2020 > New Revision: 368187 > URL: https://svnweb.freebsd.org/changeset/base/368187 > > Log: > Unbreak r368167 in userland. Decorate unused arguments. > > Reported by: kp, tuexen, jenkins, and many others > MFC with: r368167 > > Modified: > head/sys/dev/nvme/nvme.h > > Modified: head/sys/dev/nvme/nvme.h > ===================================================================== > ========= > --- head/sys/dev/nvme/nvme.h Mon Nov 30 14:49:13 2020 (r368186) > +++ head/sys/dev/nvme/nvme.h Mon Nov 30 14:51:48 2020 (r368187) > @@ -1728,9 +1728,15 @@ extern int nvme_use_nvd; > > #endif /* _KERNEL */ > > +#if _BYTE_ORDER != _LITTLE_ENDIAN > +#define MODIF > +#else > +#define MODIF __unused > +#endif > + > /* Endianess conversion functions for NVMe structs */ > static inline > -void nvme_completion_swapbytes(struct nvme_completion *s) > +void nvme_completion_swapbytes(struct nvme_completion *s MODIF) IMO, this is pretty ugly, it causes the brain to screech to a halt when you see it. Why not just add an unconditional __unused to the functions? The unused attribute is defined as marking the variable as "potentially unused" -- there is no penalty for having it there and then actually using the variable. -- Ian