From nobody Thu Apr 21 13:45:55 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ACE3311CCD9D for ; Thu, 21 Apr 2022 13:45:58 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kkf2D736Xz4cyL for ; Thu, 21 Apr 2022 13:45:56 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1650548755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xfeWKvu5fjbqZvJBak25lvm6W4D6mvthZYhgc9zvUyg=; b=mfoLKQg2eWoBNCrbTBh3zDa4gDsNJ5h4dnP2X8S1oBZDYu/FV/e0FI2aLWRE84t+vo2La/ pint8o6uDSt6grR6oXz9YLj+NSdj91NeGrk9dQNQWI19/oGqVSWVlqJLnuHu6QrB7Wfqem i6V8HVqNgsDGUGyoiT2/hveh6H0fgGU= Received: from skull.home.blih.net (lfbn-idf2-1-1209-45.w90-92.abo.wanadoo.fr [90.92.34.45]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 4ae7e8b7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 21 Apr 2022 13:45:55 +0000 (UTC) Date: Thu, 21 Apr 2022 15:45:55 +0200 From: Emmanuel Vadot To: Michael Butler Cc: freebsd-current Subject: Re: 'set but unused' breaks drm-*-kmod Message-Id: <20220421154555.8a69a542d97d6cf36472b75f@bidouilliste.com> In-Reply-To: References: <263e16c4-0634-88e6-9652-50d0874f027e@protected-networks.net> <20220421094236.3f023ac540666c140c04f884@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Kkf2D736Xz4cyL X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=mfoLKQg2; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-1.84 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_SPAM_MEDIUM(0.66)[0.655]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MLMMJ_DEST(0.00)[freebsd-current]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, 21 Apr 2022 08:51:26 -0400 Michael Butler wrote: > On 4/21/22 03:42, Emmanuel Vadot wrote: > > > > Hello Michael, > > > > On Wed, 20 Apr 2022 23:39:12 -0400 > > Michael Butler wrote: > > > >> Seems this new requirement breaks kmod builds too .. > >> > >> The first of many errors was (I stopped chasing them all for lack of > >> time) .. > >> > >> --- amdgpu_cs.o --- > >> /usr/ports/graphics/drm-devel-kmod/work/drm-kmod-drm_v5.7.19_3/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:1210:26: > >> error: variable 'priority' set but not used > >> [-Werror,-Wunused-but-set-variable] > >> enum drm_sched_priority priority; > >> ^ > >> 1 error generated. > >> *** [amdgpu_cs.o] Error code 1 > >> > > > > How are you building the port, directly or with PORTS_MODULES ? > > I do make passes on the warning for drm and I did for set-but-not-used > > case but unfortunately this option doesn't exists in 13.0 so I couldn't > > apply those in every branch. > > I build this directly on -current. I'm guessing that these are what > triggered this behaviour: > > commit 8b83d7e0ee54416b0ee58bd85f9c0ae7fb3357a1 > Author: John Baldwin > Date: Mon Apr 18 16:06:27 2022 -0700 > > Make -Wunused-but-set-variable a fatal error for clang 13+ for > kernel builds. > > Reviewed by: imp, emaste > Differential Revision: https://reviews.freebsd.org/D34949 > > commit 615d289ffefe2b175f80caa9b1e113c975576472 > Author: John Baldwin > Date: Mon Apr 18 16:06:14 2022 -0700 > > Re-enable set but not used warnings for kernel builds. > > make tinderbox now passes with this warning enabled as a fatal error, > so revert the change to hide it in preparation for making it fatal. > > This reverts commit e8e691983bb75e80153b802f47733f1531615fa2. > > Reviewed by: imp, emaste > Differential Revision: https://reviews.freebsd.org/D34948 > > Ok I see, I won't have time until monday (maybe tuesday to fix this) but if someone wants to beat me to it we should add some new CWARNFLAGS for each problematic files in the 5.4-lts and 5.7-table branches of drm-kmod (master which is following 5.10 is already good) only if $ {COMPILER_VERSION} >= 130000. Cheers, -- Emmanuel Vadot