From owner-cvs-all@FreeBSD.ORG Fri Mar 30 17:49:10 2012 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 157B21065672; Fri, 30 Mar 2012 17:49:10 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id E17678FC0A; Fri, 30 Mar 2012 17:49:08 +0000 (UTC) Received: by bkcjc3 with SMTP id jc3so1011526bkc.13 for ; Fri, 30 Mar 2012 10:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=yQ6MpYw0Ue9A2JQYVUuytclzhgCeYVrUjqdw+dQ/I7U=; b=0hC9yqkbbgRUP8RW8muFm+HKFUIP0xwpRPcNYhJfPu8YzOukM4/lvYykqa4RDUk+/J k6CwVkogE2x/b4VNnCbYsgxlp7jO3B1UxrRJ8930yy94QuADRwYDOVBPGykpUjqNAcqC xVxgxvhKKXyMp7gjZ+F43VSL8Xc/LIPrGGC1C0SMcMrJ3e77ALZOTsSbqrr6g/BY9q8h QnkpghCL7Haozjsrs6nB3nBCIUEmeq8NL1Fk0UlxreIjD9Kxi+DItsESYlhounyn3Gkf ycZgcamlYxCZnFZSTgqioJ29YEFXE76UklzMkJ8agP4EMNKow4ZlSbZbwP83VnkIK3Qi sgjA== MIME-Version: 1.0 Received: by 10.204.10.91 with SMTP id o27mr1388849bko.5.1333129747479; Fri, 30 Mar 2012 10:49:07 -0700 (PDT) Received: by 10.204.202.142 with HTTP; Fri, 30 Mar 2012 10:49:07 -0700 (PDT) Received: by 10.204.202.142 with HTTP; Fri, 30 Mar 2012 10:49:07 -0700 (PDT) In-Reply-To: <20120330171640.GA42284@ravenloft.kiev.ua> References: <201203301436.q2UEaXor009896@repoman.freebsd.org> <201203301540.40388.makc@freebsd.org> <20120330155456.GA34807@ravenloft.kiev.ua> <201203301711.10202.makc@freebsd.org> <20120330171640.GA42284@ravenloft.kiev.ua> Date: Fri, 30 Mar 2012 17:49:07 +0000 Message-ID: From: Chris Rees To: Alex Kozlov Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-ports@freebsd.org, Max Brazhnikov , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/games Makefile ports/games/drcreep Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2012 17:49:10 -0000 On 30 Mar 2012 18:17, "Alex Kozlov" wrote: > > On Fri, Mar 30, 2012 at 05:11:09PM +0000, Max Brazhnikov wrote: > > On Fri, 30 Mar 2012 18:54:56 +0300, Alex Kozlov wrote: > > > On Fri, Mar 30, 2012 at 03:40:39PM +0000, Max Brazhnikov wrote: > > > > And by the way ${ECHO_CMD} should be used, if you really need echo. > > > Do You mean ECHO_MSG? > > It depends. The bsd.command.mk says: > > > > # ECHO is defined in /usr/share/mk/sys.mk, which can either be "echo", > > # or "true" if the make flag -s is given. Use ECHO_CMD where you mean > > # the echo command. > > ECHO_CMD?= echo # Shell builtin > > > > # Used to print all the '===>' style prompts - override this to turn them off. > > ECHO_MSG?= ${ECHO_CMD} > But the Porters handbook says: > > Likewise, the distinction between ECHO_MSG and ECHO_CMD should be kept in mind. > The former is for printing informational text to the screen, while the latter > is for command pipelining. > > A good example for both can be found in shells/bash2/Makefile: > update-etc-shells: > @${ECHO_MSG} "updating /etc/shells" > @${CP} /etc/shells /etc/shells.bak > @( ${GREP} -v ${PREFIX}/bin/bash /etc/shells.bak; \ > ${ECHO_CMD} ${PREFIX}/bin/bash) >/etc/shells > @${RM} /etc/shells.bak > That is correct, ECHO_MSG is preferred for screen messages. However, pkg-message is still more appropriate here :) Chris