From owner-svn-src-all@freebsd.org Mon May 7 17:33:01 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2648FB7BAB for ; Mon, 7 May 2018 17:33:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BF157A6EE for ; Mon, 7 May 2018 17:33:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22d.google.com with SMTP id d73-v6so35112019iog.3 for ; Mon, 07 May 2018 10:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4zbBdfeGTfrQXVdxFbbrMMHDEDLldVXftXmfT2ok6zQ=; b=Dgq+Jr9si9qOZvqp6AyP9sCAecdAoQUkcoN/EZubK06QN5JX9ZRYSEQM+ggWVSHgHO ivJslmC+U4iULlXbjeW7swgnGJ6CG5+C/DJHHoGD+eKJd+se8BNAtHtIGrB3QKSbrYw0 QD6OFWqv7r/6D2xrNEUksa6qZVKyLcT2NylUGfxX/tWh2F6t81kLtMG+eQjESmXmBs04 XlbssrfaHR2lgrWcrtGCeQv9x7opucbqrNj0uEbHsgkS5S8YBFpkJFb+3hxtn+PPpKjQ 0Le/UmvHuQJ4PHzA5oVsX9++vOkByilm8TPJy5tYC243nUHBc/6WdzQZYyh8s/3sy5SW whdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4zbBdfeGTfrQXVdxFbbrMMHDEDLldVXftXmfT2ok6zQ=; b=JItF+xmFOvyze0G4kPg6Q6CsVojfuX0Ek2YRYFT0wv/IPDFYIvtumfw6D70y8QqCz5 wMBSXuOhbReVKihhKl9iABuJHOF47sTn3w0E5EzSz7sUDaylX/3lcRSIZPivW88uAdLA aCJa8UBkX9x2goYY/byBWz19f5/aKUBANqNYxaFj5Io/94pXatoE/g09+YFYmnWvnqbT iYsR9luYgeNsnuNSTtQphQEQ1NS7d0yBs1kKlRXLj8r6aczivVEahcvlwsReArbSlPcC zL5SdQb21QPQ6V4wgNomolq0VluJ1IdN2bdJuj1TvdjXuubULYwx3brmXo8kkmXyZbz/ m2Dg== X-Gm-Message-State: ALQs6tBp05NKGDAFPe2uLmZsBjEPY8Iar56wJOFiLmP1dLnYG313MNzD sePCbpIfaIHakEDDVoEPgFxkqeSr5ud/VNQx9V1h9g== X-Google-Smtp-Source: AB8JxZo3/Hu9JcqvlGUHkMIF+id3KuejFLLPQTXh5tgetJ21eaIoFXlIVLEzxVbIrT5nd1dTsTNaI+S3J73sbIzysJU= X-Received: by 2002:a6b:be01:: with SMTP id o1-v6mr39569541iof.299.1525714372184; Mon, 07 May 2018 10:32:52 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:a65a:0:0:0:0:0 with HTTP; Mon, 7 May 2018 10:32:49 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201805071728.w47HSDuD056876@pdx.rh.CN85.dnsmgr.net> References: <201805071728.w47HSDuD056876@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Mon, 7 May 2018 11:32:49 -0600 X-Google-Sender-Auth: lSBhpYf36KWOAAeFMMUrfI6hb8Y Message-ID: Subject: Re: svn commit: r333324 - in head/sys: amd64/amd64 conf To: "Rodney W. Grimes" Cc: "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 17:33:01 -0000 On Mon, May 7, 2018 at 11:28 AM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer wrote: > > > > > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > > > wrote: > > > >> + * ws@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > > > > > > > If the original is by ws@tools.de, who is this version by? > > > > Or is this simply copied from some other FreeBSD file? > > > > > > This is covered thoroughly in lines 1-10 of the commit email: > > > > > > > Author: mjg > > > ... > > > > memmove is repurposed bcopy (arguments swapped, return value added) > > > > > > > It's also trivial to see from code comparison... It noticed it right away > > while reviewing... > > I believe both you and Conrad are placing to much weight on the commit > message and no weight on the comment. Someone reading the code is not > going to have the context we presently have. > > Comments in code need to stand alone, without any context of commit > message creating them, or code else where, unless they directly > reference that code else where. > The code is 95% Wolfgang's code with the removal of the xchg %edi,%esi at the top and saving %edi into %r9 and restoring it to %rax before return. So -1 line +3 lines for a ~45 line function that affected only the arg order and return code.... The comment is entirely appropriate. Wraner