From owner-cvs-all Mon Jul 1 14:52: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAA3C37B400; Mon, 1 Jul 2002 14:52:02 -0700 (PDT) Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 04F9943E13; Mon, 1 Jul 2002 14:52:02 -0700 (PDT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (lcl234.zbzoom.net [208.236.36.234]) by pittgoth.com (8.12.4/8.12.3) with SMTP id g61Lq04f078915; Mon, 1 Jul 2002 17:52:00 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Mon, 1 Jul 2002 18:54:43 -0400 From: Tom Rhodes To: Dima Dorfman Cc: sheldonh@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent doc/en_US.ISO8859-1/articles/contributors article.sgml Message-Id: <20020701185443.17fee493.trhodes@FreeBSD.org> In-Reply-To: <20020701214430.880793E1E@turbine.trit.org> References: <20020701154046.GN85531@starjuice.net> <20020701214430.880793E1E@turbine.trit.org> X-Mailer: Sylpheed version 0.7.8claws (GTK+ 1.2.10; i386-portbld-freebsd4.6) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 01 Jul 2002 21:44:30 +0000 Dima Dorfman wrote: > Sheldon Hearn wrote: > > On (2002/07/01 08:30), Johan Karlsson wrote: > > > > > Modified files: > > > en_US.ISO8859-1/share/sgml authors.ent > > > en_US.ISO8859-1/articles/contributors article.sgml > > > Log: > > > Move myself from additional contributors to developers section. > > > Add authors entry for myself. > > > > > > Reviewed by: sheldonh (mentor) > > > Approved by: sheldonh (mentor) > > > > I have explained to Johan that Reviewed is not required when > > Approved is given. > > Isn't this backwards? "Reviewed by" implies "Approved by", but not > the other way around; a maintainer (or mentor) might "Approve" a patch > without necessarily looking at ("Reviewing") it, but someone that > "Reviewed" a patch always "Approves" it. The text you proposed for > the Committers' Guide has the same problem. > This is more of an 'interpretation' thing though. If I was a mentor or maintainer nothing would be approved without review. In both contexts their seems loss... Perhaps the committers guide can clarify everything from the rcs template. -- Tom (Darklogik) Rhodes www.FreeBSD.org -The Power To Serve www.Pittgoth.com -Pittgoth Discussion Portal trhodes@{Pittgoth.com, FreeBSD.org} PGP key by www: http://www.pittgoth.com/~darklogik/darklogik.key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message