From owner-cvs-ports@FreeBSD.ORG Sat Oct 24 11:19:11 2009 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52FC310656C0; Sat, 24 Oct 2009 11:19:11 +0000 (UTC) (envelope-from stas@deglitch.com) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id EDB758FC08; Sat, 24 Oct 2009 11:19:10 +0000 (UTC) Received: from orion.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id 9221E8FC4E; Sat, 24 Oct 2009 15:19:08 +0400 (MSD) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id 0730139C24; Sat, 24 Oct 2009 15:19:55 +0400 (MSD) Date: Sat, 24 Oct 2009 15:19:50 +0400 From: Stanislav Sedov To: Beat Gaetzi Message-Id: <20091024151950.759c5090.stas@deglitch.com> In-Reply-To: <4AE2DF85.1090007@FreeBSD.org> References: <200910231429.n9NEToUC016266@repoman.freebsd.org> <20091024143852.9be13dbe.stas@deglitch.com> <4AE2DF85.1090007@FreeBSD.org> Organization: Deglitch Networks X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Sat__24_Oct_2009_15_19_50_+0400_SfPCibfDfHBFs5ky" Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/emulators/virtualbox Makefile ports/emulators/virtualbox/files patch-configure X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2009 11:19:11 -0000 --Signature=_Sat__24_Oct_2009_15_19_50_+0400_SfPCibfDfHBFs5ky Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, 24 Oct 2009 13:05:41 +0200 Beat Gaetzi mentioned: > Stanislav Sedov wrote: > > On Fri, 23 Oct 2009 14:29:50 +0000 (UTC) > > Beat Gaetzi mentioned: > > \ > >> | # > >> | =20 > >> | PORTNAME=3D virtualbox > >> | @@ -76,6 +76,14 @@ KMK_BUILDTYPE=3D release > >> | KMK_CONFIG=3D VBOX_LIBPATH_X11=3D${LOCALBASE} VBOX_FREEBSD_SRC=3D${= SRC_BASE}/sys > >> | KMK_FLAGS=3D > >> | =20 > >> | +.if defined(WITHOUT_QT4) && !defined(WITHOUT_NLS) > >> | +BROKEN=3D NLS support requires QT4 frontend. Run 'make config' aga= in! > >> | +.endif > >> | + > >> | +.if defined(WITHOUT_X11) && !defined(WITHOUT_QT4) > >> | +BROKEN=3D QT4 frontend requires X11 support. Run 'make config' aga= in! > >> | +.endif > >> | + > >=20 > > Why not enforce these required options instead? >=20 > Lets assume a user want to install virtualbox headless on a server. He > deselect X11 and QT4 support but accidentally select NLS support. If we > enfore the required options this means we will install all the X11 and > QT4 dependencies without asking on his server. With the current checks > the user could decide if he wants to deselect NLS support or add QT4 and > X11 support. >=20 There's also a possibility to disable NLS in WITHOUT_X11 case as well. My point it that on the servers one usually have WITHOUT_X11 defined in /etc/make.conf and build ports in batch mode. As virtualbox has NLS enabled by default this commit made default configuration broken for WITHOUT_X11 case. You can just give the user a warning about disabling NLS if it conflicts with the configuration selected and go ahead. --=20 Stanislav Sedov ST4096-RIPE --Signature=_Sat__24_Oct_2009_15_19_50_+0400_SfPCibfDfHBFs5ky Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJK4uLaAAoJEKN82nOYvCd0444P/iRUtAJDKV2n5I7LkOYORF76 25DQ2m6KozPgu1E7zDHcyEsUM248ZOtRzHEpQ+//Qoa/qUjLOGXaFLTowhAj+7EV kjIc/xG2LLZBcLoSJ7OouNUzNnIQfwDWUHB7KKDRPUq7qC/oGxX16khSBBh44guM L41eYOnn2vNkFI7h2MEI/n9mpPlvAmv/uuhNdCck8mcNx+JdOgp6Zsm48+NkgdPF OippgT9ExXfiwslCAUATxFe92A+aqqrUWyC296e5ai2A40quUbXYdKPGidnd2tMm VZ7Zwwbw8O5qVe7Hc173yIuX+ZYrUooP3CqNLzp3ow9CT+XVvx8+j0RKLVNmiVOm LIdE60JcshlsFzLjzzrikLp4F8J3ki6EGyQj/NBbQSHJ5QfJ42E86giGNcMHaufs GdXLDsbu4ChKkkK6MqH5PlwJf85aNBnfv68wzttDiW0I5bv77kSQ600nW5wI63fe gZws9Xil9dmxw3ZbrFyJxTXsCY9DfHg0dhmPut0vUprSkdEU4ieNVZQfrsm7Hd9S Po3hqeohDcnZHIxcLY6u6yQutWSYCriibsb7NcwZiDrDqi85HqozS0ixEKVO7XR7 ih26i/srsRoRukrFHvl+9L9nrkSCKtxfjMTyKtLg0aac3h+7PnMoo2HkeFur5FiT m5Wcks40LGO7uVi5oLR0 =Wtsn -----END PGP SIGNATURE----- --Signature=_Sat__24_Oct_2009_15_19_50_+0400_SfPCibfDfHBFs5ky--