Date: Wed, 28 Jan 2015 17:27:05 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r277796 - in head/sys: dev/acpica dev/syscons dev/vt sys Message-ID: <20150128152705.GM42409@kib.kiev.ua> In-Reply-To: <54C8E9DE.4080709@FreeBSD.org> References: <201501271733.t0RHXJ3M058422@svn.freebsd.org> <20150127174742.GI42409@kib.kiev.ua> <54C8E9DE.4080709@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 28, 2015 at 03:53:34PM +0200, Andriy Gapon wrote: > On 27/01/2015 19:47, Konstantin Belousov wrote: > > On Tue, Jan 27, 2015 at 05:33:19PM +0000, Andriy Gapon wrote: > >> > >> + EVENTHANDLER_INVOKE(power_suspend_early); > >> + stop_all_proc(); > > It also makes sense to call syncer_suspend() after stop_all_proc(), > > I suppose. It would ensure that a failed resume still ends with the > > consistent filesystem metadata. > > Probably yes. I can make that change if you endorse it. Or you can make it if > that'll be faster. Thanks! I prefer that the change is made by somebody who uses and tests the suspension code, i.e. you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150128152705.GM42409>