Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jan 2018 14:46:00 +0000 (UTC)
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r458424 - head/editors/medit
Message-ID:  <201801081446.w08Ek0Yw026912@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: danfe
Date: Mon Jan  8 14:46:00 2018
New Revision: 458424
URL: https://svnweb.freebsd.org/changeset/ports/458424

Log:
  Quickly fix a segmentation fault when trying to open About dialog, by
  clearing `errno' prior to calling strtol(3).
  
  Typically this is not needed (return value must be checked before the
  `errno' check), but in case of strtol(3) return value can be zero for
  both successful and failed conversions.

Modified:
  head/editors/medit/Makefile

Modified: head/editors/medit/Makefile
==============================================================================
--- head/editors/medit/Makefile	Mon Jan  8 14:44:54 2018	(r458423)
+++ head/editors/medit/Makefile	Mon Jan  8 14:46:00 2018	(r458424)
@@ -36,5 +36,7 @@ post-patch:
 	@${REINPLACE_CMD} -e '/std::nullptr_t/ { x ; \
 		s/.*/#include <cstddef>/ ; G ; }' \
 		${WRKSRC}/moo/moopython/moopython-utils.h
+	@${REINPLACE_CMD} -e 's/long val = strtol/errno = 0; &/' \
+		${WRKSRC}/moo/mooutils/mooglade.c
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801081446.w08Ek0Yw026912>