From owner-dev-commits-src-all@freebsd.org Mon Jul 26 18:37:53 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B4C2E672CE9 for ; Mon, 26 Jul 2021 18:37:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GYTFF2GhXz3H8y for ; Mon, 26 Jul 2021 18:37:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f45.google.com with SMTP id l18so4561334wrv.5 for ; Mon, 26 Jul 2021 11:37:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hQzUd1O+E/RvPXed/46Oa/irbsLN4iwCICZjVrp+N4Y=; b=KKYgsASXl+Idl1R5C51CkUi6TMhi1ARu/Nd795HEw2ZxQuxpFzHzH77v11scRRmi7M le/xq5BDp8P7rY/+P+8pUlP4tvlRIRlknSTNqWu5xyukGXnrNpJ7N1DeGZTsrLbga8Wv onaYI2oo9jp3e5wFW2zQxnSHvAZmMEaHsYzuTXXV0zsoTSEGOKIVBHakcmELjvd5EYB5 Bet4DXlL0+CIKESWzeF0UyWNS34uiSrg7OcdOs/2WcZA8dfLVr91jKLoYYgWQH49lauH EFZ3EHYF0PNgu0hpr425YNyYlUg+/6O0m1Y/VLvNblm0KdO1mhtHcPOLiOopHiuU/L+X f0rw== X-Gm-Message-State: AOAM531MijYnYIRDRpvS0pY6hcHN2g/heIr8z3MkVN5C54NEQi5B+TJe PZ3xP3Qy5T5meYetA4yKilQ/kk7j+u2obA== X-Google-Smtp-Source: ABdhPJzvV9jT6yTHOk9Ir+YxW1IiPyiv9aPQWqBMvsyhX0MiR58W8EKfuM7UZ+kdTqm/6cGoAaSJ7A== X-Received: by 2002:adf:82d2:: with SMTP id 76mr20760068wrc.5.1627324666607; Mon, 26 Jul 2021 11:37:46 -0700 (PDT) Received: from smtpclient.apple (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id s6sm748260wrt.45.2021.07.26.11.37.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jul 2021 11:37:46 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: git: de273c83a10c - main - linux(4): Fix i386 gcc build. From: Jessica Clarke In-Reply-To: <202107261829.16QIThWa081478@gitrepo.freebsd.org> Date: Mon, 26 Jul 2021 19:37:45 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202107261829.16QIThWa081478@gitrepo.freebsd.org> To: Dmitry Chagin X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Rspamd-Queue-Id: 4GYTFF2GhXz3H8y X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 18:37:53 -0000 On 26 Jul 2021, at 19:29, Dmitry Chagin wrote: >=20 > The branch main has been updated by dchagin: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dde273c83a10c5807b52b7479e477854b= 77baa912 >=20 > commit de273c83a10c5807b52b7479e477854b77baa912 > Author: Dmitry Chagin > AuthorDate: 2021-07-26 18:28:16 +0000 > Commit: Dmitry Chagin > CommitDate: 2021-07-26 18:28:16 +0000 >=20 > linux(4): Fix i386 gcc build. >=20 > Do not specify memory model for i386. Seems that clang silencly > ignores -mcmodel unlike gcc. >=20 > Reported by: jhb > MFC after: 2 weeks > --- > sys/modules/linux/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/sys/modules/linux/Makefile b/sys/modules/linux/Makefile > index 1304c2d91fd8..bf4449e0012e 100644 > --- a/sys/modules/linux/Makefile > +++ b/sys/modules/linux/Makefile > @@ -60,20 +60,20 @@ linux${SFX}_assym.h: linux${SFX}_genassym.o > sh ${SYSDIR}/kern/genassym.sh linux${SFX}_genassym.o > = ${.TARGET} >=20 > .if ${MACHINE_CPUARCH} =3D=3D "amd64" > -VDSOFLAGS=3D-DCOMPAT_FREEBSD32 -DCOMPAT_LINUX32 -m32 > +VDSOFLAGS=3D-DCOMPAT_FREEBSD32 -DCOMPAT_LINUX32 -m32 -mcmodel=3Dsmall This just shifts the problem. You=E2=80=99ve fixed it if building an = i386 kernel, but not if building an amd64 kernel with linux32 support. This line should just be reverted and everything should work fine. Jess