From owner-freebsd-toolchain@freebsd.org  Fri Aug 26 10:56:24 2016
Return-Path: <owner-freebsd-toolchain@freebsd.org>
Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4FD2EA94111
 for <freebsd-toolchain@mailman.ysv.freebsd.org>;
 Fri, 26 Aug 2016 10:56:24 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C2DF2935;
 Fri, 26 Aug 2016 10:56:23 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u7QAuI8u062139
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Fri, 26 Aug 2016 13:56:18 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u7QAuI8u062139
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id u7QAuIH1062138;
 Fri, 26 Aug 2016 13:56:18 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Fri, 26 Aug 2016 13:56:18 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Pedro Giffuni <pfg@FreeBSD.org>
Cc: freebsd-toolchain@FreeBSD.org
Subject: Re: Time to enable partial relro
Message-ID: <20160826105618.GS83214@kib.kiev.ua>
References: <b75890eb-d8bd-759e-002f-ab0c16db0975@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b75890eb-d8bd-759e-002f-ab0c16db0975@FreeBSD.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2016 10:56:24 -0000

On Thu, Aug 25, 2016 at 05:50:31PM -0500, Pedro Giffuni wrote:
> Hello;
> 
> GNU RELRO support was committed in r230784 (2012-01-30) but we never 
> enabled it by default.
> 
> There was some discussion about it on
> https://reviews.freebsd.org/D3001
> 
> By now, all Linux distributions, NetBSD and DragonFly support it and
> it is the default for most systems in binutils 2.27.
> 
> This doesn't affect performance, I ran it through an exp-run last
> year, no other OS has had issues etc ... seems safe and can be
> disabled if needed when linking.
Exp-run does not test anything interesting about relro. If all testing
that was done is basically just an exp-run, then there was no useful
runtime testing done.

> 
> I think it's time to enable it be default in our base binutils. If
> there are no objections, I will just commit the attached patch over
> the weekend.

There are objections, the change must be runtime tested on large and
representative set of real-world applications before turning the knob.