From owner-freebsd-net@freebsd.org Mon Feb 25 20:38:59 2019 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A12021515921 for ; Mon, 25 Feb 2019 20:38:59 +0000 (UTC) (envelope-from kempe@lysator.liu.se) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DAD3480C34 for ; Mon, 25 Feb 2019 20:38:58 +0000 (UTC) (envelope-from kempe@lysator.liu.se) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id D37644000F for ; Mon, 25 Feb 2019 21:38:54 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id AF0714000A; Mon, 25 Feb 2019 21:38:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from drd1812.nothing.org (unknown [10.253.196.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 2970840004; Mon, 25 Feb 2019 21:38:54 +0100 (CET) Subject: Re: Infiniband: Mellanox MT26418 in ethernet mode causes crash on shutdown To: Hans Petter Selasky , freebsd-net@freebsd.org, freebsd-drivers References: <8763252f-d433-5e1e-9e3b-628e0545c8eb@lysator.liu.se> <940f6859-037b-68d6-298a-513ea6ebf7ce@selasky.org> From: Andreas Kempe Openpgp: preference=signencrypt Autocrypt: addr=kempe@lysator.liu.se; keydata= mQINBFfcARkBEACpvItp92qIKstHBKcdfFFq7/Kd52IyQuOvLtJCn9Cvbipn48wxWBc2Ytzq OT0VueYpsX85VbJkCB8aTCVfm3xlHHozbttJbwRiQuoRPQFdaRMQacaSg7g9A8DZmIshHbzk hvDw20Exa/d3B4mX/LHewWyR/v34Aw0t1OchuI/xN2qpTgTINkY4vyA057/088dbTz7Kfs5P 3TCzrycULgoke96jrAy6hjUOSHCPvLPXnQ9mq9q0u1yXpK1WnG91aU1qhSiY7ya4Sj+UkSok T5qiV08K49IJdLNvs32FRaizJqHUrdXHsel2xFAnSssqwjq/qWinR8XIZCRtuf8Vcg+/cihM KWbrEvDsnWPmzWRk4HjFmUfXTBN6NpDq5teWQmcHUxCkIG15vEa7twUlDfSfFdW2tThglz/M i2IlinT5mCa213s1mv0xRTKY/QnWQgrVK4m6gAL2vt4TQ0f/2KE7OFm4vS4HJCrleMKIROEE iycYHsFjdzL55JBm5idAPTg/da07WJZBxAIFLLvbm4XawRzyeuNCPUZt030A6OszTfV8+1XZ cB+qU2pxiD6VLfoW/HIZNLpZDTl+DkrPHK5FeVl3rMpCroWwFrZkWAWlDgRseupdbOkmiplj cqKiRoQ7414jW8PwVzHWuHZ/JDALO3JrinsBRKCiJ6wpyw1K1wARAQABtCRBbmRyZWFzIEtl bXBlIDxrZW1wZUBseXNhdG9yLmxpdS5zZT6JAlgEEwECAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheABQkFhWQCFiEETci4cPcl+ZcyiACiCkqKrhcKSD0FAlvxTwICGQEACgkQCkqK rhcKSD3I0hAAn0/l5GRdVrkAPrNx1DZp/3RQmEwQUZJC/0hSi7JFZHfgoA7AHeg2oVY36KAy q2oTEzA2OsDKKs6T66+CLedIpDwVKE7KPcSswHbM0ULB8sE/Kymha/+db6xQzglJtnlLEJEn OyV09exX9rqyazpAQ4/TohthrDbMqYU+MZUIULZz83Hat+Fdi4K6CwCdl4NC05xsVIDNEJks 3DivlUccZ0GX6Bx1sTYO7mSL1v4mUpEf/BWOLqm9PFyU9jniQVuabYcfPnLn/xmwXZUcTEe4 iyBzlKxDhbnFyyxG7A8N/8UDWte59t843Q+KBA6WknWorG4gmwEhGE7pB4hTFU8gM+KGm89T RZiINbYaHI/OJ2p0R2cY/LU1XGw5A5WFvLXgqAO3196KLqjKz11VHeTWI/KeZ+QAPccShZKh yXbu+cYdqfYpGRlnSx0mzCvi5NfJQw+HTIA6EMnlcc+vfsnn4X0RO4BcGoqnThIkQYWVwZPC ZxAxDciifEMdJ374eaxmORlW3hvPDHmowPST/8H6ln3nWvhZRncGcWj4Gz0QuoB6V0JKgUaV zI5NBIbpi0U/1FdB6HtWK7KH86KNvXT6FG49yNPMnnYX9Nnt/3IyTlpl4rp0zuAE5gxj9Z06 Sko5+jO2iJ6T0147cjhmiTLGySfi+kavAX0fdRSy3SxSxPC5Ag0EV9wBGQEQANRvDM/LiHoq bAGAs1IgCcSGWdcdE2pcmMTeaxH/9ZY28tyIwrnjuuYdAZwrVFgNaRlSKB/VXJ7p1Pkir2PT ruvhvhdsRQsBV56KXw55WYpN+FizQbWftvRpGy0AV/UlCtba2pxNyo1kSYUh3Lati+uIRWcp zB2ctLQ/ib58S4Kft6ZvPXLoAEMkkj/dNZDG3kK0Wr1eB30LnpxQC38EMbIDvsVt2csfFZUd qjpn0dAjJNEsWCs9WrBclYBl/TDFmyfbc4CvrVgizFdt4tKX3VK7uGXUfSHSF7CFkvqViW7D AE+p7cvkd6wwf45ivRlAe0bOiV8DzW90c7F4WbGoM+hydDeSOYy5T4ttE8mZCi/XtdZuxUBB kOUuUs0yBPYk/kdeSSvPcUep2zs3JK5Vn+pikwTsGrrYthBgrwZ3WntWHaRsinPTd3uAn5i+ 7depjtzUwz4h+s4JiCYYSKFoNyet27xF3MgT8+y5O6GkdFXoCHQ0XfsW6CU7GEdbcCWpecvh EuwrOmjFfHHd+jVMUzekUxFD49qjxKn4tZdNm/mM7zZaefjps2Srw7EzZI0sJIld1LG9dcB9 vYeunOZ4JuMo9xtTgqEW74avoxsRWvvTYMRYCWIlm5azzbqxpTSxnbicCFaEkUhye8OBdm3r eb3tk7a7m+k+sb1kV40lCMRhABEBAAGJAiUEGAECAA8CGwwFAluAMdsFCQWFZEIACgkQCkqK rhcKSD3hWw//enGvZy6YymqrxAVXBywC9BBh/Nact9O3LZ/l2PI0JSqn2+gQuqUl69SYpTuu npo4edw0DCzhFPbeND4dZP8d/iBp+AUkm+fNqtK33yNsVp6iwVqfE1fSWGT+9dqIy2uCNn09 rW2ry02l+BBzWAvOtNVdYEGx73IiIQbGMzjVCb/UCBmTbRk77svXKST97tgrMiO21KWbyDVG RgMMJSeLFnLKoWxhHUJTwwlUtOQgdVpUoZAg75Ca6LokV//e+hWXs+jcdsKLm59ZpwAxg0Am 255vdtIwaRiI3RMJ7L0+Hi9czicdx/dBo+ie5A7Ky+uKPaLIh18UeYcf9LH96wRf1ifHn8eQ ztx5Am1CMHGM8o1dd6g4ofU/dGGAT53vZAKKnZsZsYVLuvfXATdRsNpaCYBGtKlNHXQ9ZkJX gLEtUSmlq9dSRmMrDx5sK1BURkTA+UCOFqX+hSVqATDabhkaOXoR20nE1kSGpYKmfOA0eJTN 89EYGey7x3YHIBLeq/a3pFuI6AuGLXIifNzzRTyvdIwgkT77kQPmXzWybtyyc0IMSV/tBkru f70YQq+CgeA6uUFvRrRy7rP8gnWjVHguB8pwUC8Y35ibjK4ExkSpSctQXSfQ7IzDgK8IyGH4 gjRhOx2pI57kIj0vDFSpQjM8klDD7tqE/uCor1yqIdkv1r4= Message-ID: <66c8a5f3-0351-e125-41fb-66ee39cc4106@lysator.liu.se> Date: Mon, 25 Feb 2019 21:38:53 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <940f6859-037b-68d6-298a-513ea6ebf7ce@selasky.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 20:38:59 -0000 On 2019-02-25 10:28, Hans Petter Selasky wrote: > I think the if_down() call is not strictly needed. ether_ifdetach() > already does this. Can you test the patch w/o the if_down() call? > I only added the call because I was not sure what would happen if you destroy the port for an active interface. If it could cause issues if operations are performed on the interface while it is being destroyed. That said, I've tested without the call to if_down() and it seems to work. Cordially, Andreas Kempe