From owner-cvs-all@FreeBSD.ORG Tue Sep 12 06:51:29 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A663516A403; Tue, 12 Sep 2006 06:51:29 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14B0F43D46; Tue, 12 Sep 2006 06:51:28 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id 106135EA8; Tue, 12 Sep 2006 10:51:27 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id E10BA5EA7; Tue, 12 Sep 2006 10:51:26 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k8C6pYGq010112; Tue, 12 Sep 2006 10:51:34 +0400 (MSD) (envelope-from ru) Date: Tue, 12 Sep 2006 10:51:34 +0400 From: Ruslan Ermilov To: Yar Tikhiy Message-ID: <20060912065134.GA10039@rambler-co.ru> References: <200609081309.k88D9GCQ077401@repoman.freebsd.org> <20060908100034.M18039@odysseus.silby.com> <20060908154824.GK40020@FreeBSD.org> <20060911003357.V23530@odysseus.silby.com> <20060911142826.GG27667@FreeBSD.org> <20060911223812.GA1439@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <20060911223812.GA1439@comp.chem.msu.su> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: cvs-src@FreeBSD.org, Mike Silbersack , Gleb Smirnoff , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2006 06:51:29 -0000 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 12, 2006 at 02:38:13AM +0400, Yar Tikhiy wrote: > On Mon, Sep 11, 2006 at 06:28:26PM +0400, Gleb Smirnoff wrote: > > On Mon, Sep 11, 2006 at 12:36:57AM -0500, Mike Silbersack wrote: > > M> >It stops creating any state (nor socket neither compressed tcptw) f= or the > > M> >TCP connection, where both endpoints were local. This save a lot of > > M> >resources on servers running HTTP accelerators, or database=20 > > M> >servers+clients. > > M>=20 > > M> I think that you should change the description to say "Do not create= TCP=20 > > M> TIME_WAIT entries for local <-> local connections" (or something sim= ilar)=20 > > M> to remove the ambiguity, and turn it on by default for 7. This seem= s like=20 > > M> a good idea, I'm jealous that I didn't think of it. :) > >=20 > > OOh, the sysctl name and its description were discussed with ru@, who > > is our famous nitpicker. If you want to change name or description - > > mail to him. /me hides >=20 > (It was me who suggested a different name for the sysctl in question.) >=20 > IMHO it's time to define a general style for new sysctl names. > The first two points could be a) "foo" vs. "nofoo" for boolean > knobs, and b) underscore usage. >=20 > Presently there seem to be few "nofoo" knobs in the system, e.g.: >=20 > # sysctl -aN | fgrep .no > kern.nodump_coredump -- should be coredump_nodump > net.inet6.icmp6.nodeinfo -- false match > debug.nosleepwithlocks > dev.fxp.0.noflow >=20 > I don't think new ones should be introduced; their logic would be > unnecessarily vague. >=20 > OTOH, there are enough sysctl names containing an underscore to > encourage using it in complex names. An exception could be made > for really short names, such as consisting of not more than 2 words, > each being not longer than 4 letters. >=20 > What do you think about that, folks? >=20 Fine with me, if *you* want to change that. Also fine with me if the default is changed to "don't create" (if there's a consensus on this). We wanted to be on the safe side with this commit, so the default was to preserve the old behavior for POLA reasons. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFBlj2qRfpzJluFF4RAiDuAJ9Rd6A0uQrrBgLyMN6XwycR5LbjoACeIYNd PIZArf8MPe2LFQ+EYIDER6I= =OnQy -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--