Date: Thu, 8 Nov 2001 07:02:57 -0800 (PST) From: David Wolfskill <david@catwhisker.org> To: freebsd-stable@FreeBSD.ORG, K.J.Koster@kpn.com Subject: Re: Kernel build error: conflicting types for `make_dev' Message-ID: <200111081502.fA8F2vq84354@bunrab.catwhisker.org> In-Reply-To: <59063B5B4D98D311BC0D0001FA7E452205FDA078@l04.research.kpn.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>From: "Koster, K.J." <K.J.Koster@kpn.com>
>Date: Thu, 8 Nov 2001 15:18:36 +0100
>I seem to get kernel build errors (cvsup.no as of thirty minutes ago). I'm
>off to cvsup again to retry, but I'd appreciate your input.
>cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
>-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual
>-fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include
>-I../../contrib/ipfilter -D_KERNEL -include opt_global.h -elf
>-mpreferred-stack-boundary=2 ../../kern/kern_conf.c
>../../kern/kern_conf.c:293: conflicting types for `make_dev'
>../../sys/conf.h:286: previous declaration of `make_dev'
>*** Error code 1
Right. It appears to me as if the latest change to -STABLE's sys/sys/conf.h
(which was an MFC against the declaration of make_dev) was a little
incomplete, in that it didn't also change the definition of make_dev in
sys/kern/kern_conf.c.
I sent a note about it to Warner, with a subsequent follow-up to report
that the following patch enabled my kernl to build & boot:
Index: sys/kern/kern_conf.c
===================================================================
RCS file: /cvs/freebsd/src/sys/kern/kern_conf.c,v
retrieving revision 1.73.2.1
diff -u -r1.73.2.1 kern_conf.c
--- sys/kern/kern_conf.c 24 Jul 2001 09:49:41 -0000 1.73.2.1
+++ sys/kern/kern_conf.c 8 Nov 2001 13:17:10 -0000
@@ -289,7 +289,7 @@
}
dev_t
-make_dev(struct cdevsw *devsw, int minor, uid_t uid, gid_t gid, int perms, char *fmt, ...)
+make_dev(struct cdevsw *devsw, int minor, uid_t uid, gid_t gid, int perms, const char *fmt, ...)
{
dev_t dev;
va_list ap;
(I'd show you the uname output, but the machines in question are busily
building today's -CURRENT as I type....)
Cheers,
david
--
David H. Wolfskill david@catwhisker.org
As a computing professional, I believe it would be unethical for me to
advise, recommend, or support the use (save possibly for personal
amusement) of any product that is or depends on any Microsoft product.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111081502.fA8F2vq84354>