From nobody Mon Sep 12 04:07:23 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MQtNH1bGlz4cJlG for ; Mon, 12 Sep 2022 04:07:27 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MQtNG3FQ3z43rt for ; Mon, 12 Sep 2022 04:07:26 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f46.google.com with SMTP id o5so2236519wms.1 for ; Sun, 11 Sep 2022 21:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Hrn/vMcdxgeKQ1MGXYXsf2/oyd4l+zvhTxlV6tk8z7c=; b=WDJ3pXCXmU4qsARGedFMJZtwTqsiXKNFzmkHqdxiH/x8X8yRBXG5j4j837dyJIUCOI QKmlV3LkIpBixODrp5KUA9VApx0kI30KZo8cectXwmIv3g/tkf4R3QuVSS6YYDRYY9E0 fob2qS3d5yK42wgYWUleWmsLwlvFmws1sKTCe84GgwUenGjiR5qrH/WWRYZ9uCciC2VH 16pZLsywjVCtZDuXdow8vbEyeVL5Bza10ynuxRKgbksG/xMOAqUsBaxszXP3tYyWW+R+ J3/ZSHzBBK+/9uv7lkYXJyuZLYe8GfzpEkuT8hi96NyKaJSallqLG4AzHpMAqzc1o2tE CSmg== X-Gm-Message-State: ACgBeo1ZeweB46a6174m5X0PVst8FP761qaMM/8fQLR0uo1Q+yx0X/Ex TAzutvp1cI43QzvZgTdFK1JINg== X-Google-Smtp-Source: AA6agR5ATNCENcg7LnssM6T2SuNvkboNA5lCRuC0ceP7Kh6x/qgG0r+Wp0s2iLZyCtQpZvBwL9Zufw== X-Received: by 2002:a7b:cc10:0:b0:3b4:4944:5013 with SMTP id f16-20020a7bcc10000000b003b449445013mr8818172wmh.8.1662955644886; Sun, 11 Sep 2022 21:07:24 -0700 (PDT) Received: from smtpclient.apple (global-5-141.n-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id b14-20020a5d634e000000b00228da396f9dsm6010302wrw.84.2022.09.11.21.07.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Sep 2022 21:07:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 7d0e83c60bed - main - arm: add dwc3/xhci as build options for ARM From: Jessica Clarke In-Reply-To: <28B3D50F-6699-4BCE-A6C6-3BEC4785EB6F@freebsd.org> Date: Mon, 12 Sep 2022 05:07:23 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <242CC11F-A906-4B03-B3BF-EAC2677B6A8E@freebsd.org> References: <202209120236.28C2arB7033900@gitrepo.freebsd.org> <28B3D50F-6699-4BCE-A6C6-3BEC4785EB6F@freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4MQtNG3FQ3z43rt X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.46:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.46:from] X-ThisMailContainsUnwantedMimeParts: N On 12 Sept 2022, at 04:53, Jessica Clarke wrote: >=20 > On 12 Sept 2022, at 03:36, Adrian Chadd wrote: >>=20 >> The branch main has been updated by adrian: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D7d0e83c60bedf601e61d80187cdfa785= fa4b1963 >>=20 >> commit 7d0e83c60bedf601e61d80187cdfa785fa4b1963 >> Author: Adrian Chadd >> AuthorDate: 2022-09-11 23:57:52 +0000 >> Commit: Adrian Chadd >> CommitDate: 2022-09-12 02:36:42 +0000 >>=20 >> arm: add dwc3/xhci as build options for ARM >=20 > dwc3 already was there? Also, xhci already exists for arm and pulls in the generic PCI-based XHCI driver in sys/conf/files. What you really mean is that you added generic_xhci(_fdt) to arm kernels as needed by dwc3. Jess >> Summary: >> This mirrors the recentish changes to armv8; the ipq4018 port uses >> dwc3 + xhci and thus needs this. >>=20 >> Subscribers: imp, andrew >>=20 >> Reviewed by: imp >>=20 >> Differential Revision: https://reviews.freebsd.org/D36530 >=20 > This is not the right format for commit messages. >=20 > Jess >=20 >> --- >> sys/conf/files.arm | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >>=20 >> diff --git a/sys/conf/files.arm b/sys/conf/files.arm >> index 85afa4893d3c..c7e8a52a813d 100644 >> --- a/sys/conf/files.arm >> +++ b/sys/conf/files.arm >> @@ -99,7 +99,10 @@ dev/psci/psci.c optional = psci >> dev/psci/smccc_arm.S optional psci >> dev/syscons/scgfbrndr.c optional sc >> dev/uart/uart_cpu_fdt.c optional uart fdt >> -dev/usb/controller/dwc3.c optional fdt dwc3 >> + >> +dev/usb/controller/dwc3.c optional fdt dwc3 >> +dev/usb/controller/generic_xhci.c optional xhci >> +dev/usb/controller/generic_xhci_fdt.c optional xhci fdt >>=20 >> kern/msi_if.m optional intrng >> kern/pic_if.m optional intrng >=20