From owner-svn-ports-head@freebsd.org Mon Sep 2 00:25:08 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4DD31CB445; Mon, 2 Sep 2019 00:25:08 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M9pC3QVPz42K4; Mon, 2 Sep 2019 00:25:07 +0000 (UTC) (envelope-from ultima1252@gmail.com) Received: by mail-io1-f47.google.com with SMTP id b136so1726230iof.3; Sun, 01 Sep 2019 17:25:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tUw8UAnlQx9YDCdQMTmRCEUFx6QGtHwgcLdxc50rq9o=; b=TyjQzUqT+rm9HKyg/YzBgfUyjKcizHZgAV9DWgQEiaIyO4iUUD9HsGCKtWKbuj2NDc fllFiYU1di4mirsHWDD4lxZEqPK+ebuiAzU96lChN2RpCZJMNJ/jrombpBbbQ4VEZSd2 L84ncGpqOUxZrvz2MKxeJfSjZwxc6xovNntDh53gwBvyxBo5lpbrbU11nnHH4L/FSFMd kpymA7fdah7/DUBW0rqpLXOb9GDSFoTfuCgONwrTUntE5ulW5GTQUU05YrN42QHGeujk OoHvmJ7Gxs1cKbyQ9wUkHwn2k2CKMzrV9Yo3N/Rve+LhOSEjK4oSen5W25By/xBIycio Yrvg== X-Gm-Message-State: APjAAAV2RpCNJRi7xS/GE3eG4mtxt4fgkTKr1ubZgYezSTiE/+7ZlAXU Wdam6KGMKYUu3ZbUbEHXmEjMU54D X-Google-Smtp-Source: APXvYqzirFfeF/5WFdDA+HHGGIO6QPhKkHPYauMhzaE729TopHWPfPFJwNaqYf2hn19+57E18VRoNw== X-Received: by 2002:a6b:7807:: with SMTP id j7mr17077576iom.224.1567383906078; Sun, 01 Sep 2019 17:25:06 -0700 (PDT) Received: from mail-io1-f47.google.com (mail-io1-f47.google.com. [209.85.166.47]) by smtp.gmail.com with ESMTPSA id 6sm11199723iog.40.2019.09.01.17.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Sep 2019 17:25:04 -0700 (PDT) Received: by mail-io1-f47.google.com with SMTP id n197so23885452iod.9; Sun, 01 Sep 2019 17:25:04 -0700 (PDT) X-Received: by 2002:a5d:9714:: with SMTP id h20mr15753602iol.294.1567383904638; Sun, 01 Sep 2019 17:25:04 -0700 (PDT) MIME-Version: 1.0 References: <201909012248.x81MmkOA034522@repo.freebsd.org> In-Reply-To: <201909012248.x81MmkOA034522@repo.freebsd.org> From: Ultima Date: Sun, 1 Sep 2019 17:24:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r510747 - head/www/libevhtp To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 46M9pC3QVPz42K4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ultima1252@gmail.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=ultima1252@gmail.com X-Spamd-Result: default: False [-4.25 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_NONE(0.00)[]; URI_COUNT_ODD(1.00)[9]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[ultimasbox.com]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; RCVD_IN_DNSWL_NONE(0.00)[47.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.27)[ip: (-5.66), ipnet: 209.85.128.0/17(-3.34), asn: 15169(-2.31), country: US(-0.05)]; FORGED_SENDER(0.30)[ultima@ultimasbox.com,ultima1252@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[ultima@ultimasbox.com,ultima1252@gmail.com]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2019 00:25:08 -0000 Had my vocabulary mixed up on the commit message, stack = buffer and buffer = heap. On Sun, Sep 1, 2019 at 3:48 PM Richard Gallamore wrote: > Author: ultima > Date: Sun Sep 1 22:48:46 2019 > New Revision: 510747 > URL: https://svnweb.freebsd.org/changeset/ports/510747 > > Log: > Fix stack overflow that can occur in libevhtp > > libevhtp allocates a stack based on data length > when C99 is detected at compile time. There are > no checks to verify that the stack is big enough > which can cause a stack overflow. > > Adding EVHTP_HAS_C99=false at compile time changes > this behavior by allocate to a buffer which has > proper checks in place. > > More information about this bug can be found at: > https://github.com/criticalstack/libevhtp/issues/118 > https://github.com/haiwen/seafile/issues/1928 > > MFH: 2019Q3 > > Modified: > head/www/libevhtp/Makefile > > Modified: head/www/libevhtp/Makefile > > ============================================================================== > --- head/www/libevhtp/Makefile Sun Sep 1 21:48:44 2019 (r510746) > +++ head/www/libevhtp/Makefile Sun Sep 1 22:48:46 2019 (r510747) > @@ -2,7 +2,7 @@ > > PORTNAME= libevhtp > PORTVERSION= 1.2.16 > -PORTREVISION= 3 > +PORTREVISION= 4 > CATEGORIES= www > > MAINTAINER= ultima@FreeBSD.org > @@ -19,7 +19,8 @@ USE_GITHUB= yes > GH_ACCOUNT= criticalstack > > CMAKE_ARGS= -DCMAKE_INCLUDE_PATH:PATH=include/event2 \ > - -DCMAKE_LIBRARY_PATH:PATH=lib/event2 > + -DCMAKE_LIBRARY_PATH:PATH=lib/event2 \ > + -DEVHTP_HAS_C99:BOOL=FALSE > > PLIST_SUB= PORTVERSION=${PORTVERSION} > > >