From owner-dev-commits-src-all@freebsd.org Tue Mar 9 15:38:15 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B38BE556D50; Tue, 9 Mar 2021 15:38:15 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dvzr74jnrz4bK9; Tue, 9 Mar 2021 15:38:15 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: lwhsu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8F789267BA; Tue, 9 Mar 2021 15:38:15 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by mail-yb1-f179.google.com with SMTP id x19so14432697ybe.0; Tue, 09 Mar 2021 07:38:15 -0800 (PST) X-Gm-Message-State: AOAM530i2hq8qKlbeGoEmwr6XIxPFMYbkfyMivddZsj7xHKReEDldFwV rPt7Cy60HzQq/ridKrxJlzsOYtP+kY6od9Ys0W8= X-Google-Smtp-Source: ABdhPJyvf5kmkM07ai8Ev3IKgTVmkk9kcZHRmPbYFPLeY9QKzM1RL8d84Ix+VyjO3CgnJvv5WQY9El+jk4Xsu8sZh9E= X-Received: by 2002:a25:34d5:: with SMTP id b204mr40863558yba.497.1615304295053; Tue, 09 Mar 2021 07:38:15 -0800 (PST) MIME-Version: 1.0 References: <202103091117.129BHOZa042851@gitrepo.freebsd.org> In-Reply-To: <202103091117.129BHOZa042851@gitrepo.freebsd.org> From: Li-Wen Hsu Date: Tue, 9 Mar 2021 23:38:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 1ae20f7c70ea - main - kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() To: Kyle Evans Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2021 15:38:15 -0000 On Tue, Mar 9, 2021 at 7:18 PM Kyle Evans wrote: > > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1ae20f7c70ea16fa8b702e409030e170df4f5c13 > > commit 1ae20f7c70ea16fa8b702e409030e170df4f5c13 > Author: Kyle Evans > AuthorDate: 2021-03-08 06:16:27 +0000 > Commit: Kyle Evans > CommitDate: 2021-03-09 11:16:39 +0000 > > kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() > > Simple condition flip; we wanted to panic here after epoch_trace_list(). > > Reviewed by: glebius, markj > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D29125 > --- > sys/kern/kern_malloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/kern/kern_malloc.c b/sys/kern/kern_malloc.c > index 48383358e3ad..0d6f9dcfcab7 100644 > --- a/sys/kern/kern_malloc.c > +++ b/sys/kern/kern_malloc.c > @@ -537,7 +537,7 @@ malloc_dbg(caddr_t *vap, size_t *sizep, struct malloc_type *mtp, > #ifdef EPOCH_TRACE > epoch_trace_list(curthread); > #endif > - KASSERT(1, > + KASSERT(0, > ("malloc(M_WAITOK) with sleeping prohibited")); > } > } I guess this reveals a bug in gmirror? Now the test case sys/geom/class/mirror/8_test:main panics: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/17779/console https://ci.freebsd.org/job/FreeBSD-main-i386-test/11831/console Li-Wen