From owner-freebsd-current Sun May 31 08:29:07 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA04558 for freebsd-current-outgoing; Sun, 31 May 1998 08:29:07 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from sanewo.ba2.so-net.ne.jp (root@p84b44a.sng2.ap.so-net.ne.jp [210.132.180.74]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA04548 for ; Sun, 31 May 1998 08:28:46 -0700 (PDT) (envelope-from sanewo@ba2.so-net.ne.jp) Received: from ba2.so-net.ne.jp (sanewo@sanewo.ba2.so-net.ne.jp [127.0.0.1]) by sanewo.ba2.so-net.ne.jp (8.8.8/8.8.8) with ESMTP id AAA00170; Mon, 1 Jun 1998 00:27:39 +0900 (JST) (envelope-from sanewo@ba2.so-net.ne.jp) Message-Id: <199805311527.AAA00170@sanewo.ba2.so-net.ne.jp> To: Garrett Wollman Cc: current@FreeBSD.ORG Subject: Re: top -osize In-reply-to: wollman@khavrinen.lcs.mit.edu's message of Sun, 31 May 1998 10:53:51 -0400. <199805311453.KAA18088@khavrinen.lcs.mit.edu> X-Emacs: Emacs 20.2, MULE 3.0 (MOMIJINOGA) MIME-Version: 1.0 (generated by SEMI 1.4.5 - "Tomari") Content-Type: text/plain; charset=ISO-2022-JP Date: Mon, 01 Jun 1998 00:27:38 +0900 From: SANETO Takanori Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In article <199805311453.KAA18088@khavrinen.lcs.mit.edu> Garrett Wollman said: >< said: > >> int >> -proc_compare(pp1, pp2) >> +compare_cpu(pp1, pp2) > >> struct proc **pp1; >> struct proc **pp2; > >qsort(3) comparison functions take arguments of type `const void *', >not `struct proc **'. Yes, you are right. My patch does not change the way comparison functions being (not) prototyped. In contrib/top/top.c: >#ifdef ORDER >extern int (*proc_compares[])(); >#else >extern int proc_compare(); >#endif Is it time to create a patch to make them prototyped and send it to the maintainer of ``top''? -- さねを To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message