From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 02:06:20 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 58C74F80 for ; Fri, 20 Feb 2015 02:06:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 15227A0C for ; Fri, 20 Feb 2015 02:06:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K26JZP053102 for ; Fri, 20 Feb 2015 02:06:19 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K26JmZ053101; Fri, 20 Feb 2015 02:06:19 GMT (envelope-from root) Date: Fri, 20 Feb 2015 02:06:19 +0000 To: freebsd-net@freebsd.org From: "wblock (Warren Block)" Subject: [Differential] [Commented On] D1438: FreeBSD callout rewrite and cleanup Message-ID: <29ec736ba26cbbc4fd86895a120c57df@localhost.localdomain> X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTmlps= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 02:06:20 -0000 wblock added inline comments. INLINE COMMENTS share/man/man9/timeout.9:98 Missing the word "if". share/man/man9/timeout.9:126 British->American: s/behaviour/behavior/ share/man/man9/timeout.9:140 Add comma after "zero". share/man/man9/timeout.9:295 Use "cannot". "can not" with a space means "not doing it is allowed". share/man/man9/timeout.9:308 s/timeouts./timeouts are needed./ share/man/man9/timeout.9:362 s/by/by the/ share/man/man9/timeout.9:364 s/CPU/the CPU/ share/man/man9/timeout.9:370 If this means "CPU selection cannot be changed while the callout subsystem is processing the callback for completion.", then s/can not/cannot/. share/man/man9/timeout.9:378 s/by the/by/ Either "given by the func argument will" or "given by func will". The second is less wordy, REVISION DETAIL https://reviews.freebsd.org/D1438 To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net