From owner-freebsd-ports Wed Oct 11 7: 6: 9 2000 Delivered-To: freebsd-ports@freebsd.org Received: from bmah-freebsd-0.cisco.com (bmah-freebsd-0.cisco.com [171.70.84.42]) by hub.freebsd.org (Postfix) with ESMTP id 4E31637B503; Wed, 11 Oct 2000 07:06:06 -0700 (PDT) Received: (from bmah@localhost) by bmah-freebsd-0.cisco.com (8.11.0/8.11.0) id e9BE66559577; Wed, 11 Oct 2000 07:06:06 -0700 (PDT) (envelope-from bmah) Message-Id: <200010111406.e9BE66559577@bmah-freebsd-0.cisco.com> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Jeremy Lea Cc: Nat Lanza , ports@FreeBSD.ORG Subject: Re: adding '-gnome' and '-gtk' to package names In-Reply-To: <20001010182014.R30468@shale.csir.co.za> References: <20001010182014.R30468@shale.csir.co.za> Comments: In-reply-to Jeremy Lea message dated "Tue, 10 Oct 2000 18:20:14 -0700." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.ORG X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_-1438536511P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Wed, 11 Oct 2000 07:06:06 -0700 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org --==_Exmh_-1438536511P Content-Type: text/plain; charset=us-ascii If memory serves me right, Jeremy Lea wrote: > Hi, > > On Tue, Oct 10, 2000 at 02:21:08PM -0400, Nat Lanza wrote: > > Also, it breaks pkg_version, which is really annoying: > > > > # pkg_version -v > > [ elided ] > > sawfish-gnome-0.31.1 ? unknown in index > > [ elided ] > > xscreensaver-gtk-3.24 ? unknown in index > > > > Please consider backing out this change. > > No. These are very important. They tell you when optional support has > been added for a port. As for pkg_version, the current solution is to > add slave makefiles for all of the various option based ports (not just > the GNOME/GTK+ ones, but also the i18n ones, the mysql ones, the x11 > ones...). A more offical route would be to remove the -'s from all of > the ports which are not supposed to have them in their names (there are > a bunch, and have pkg_version only compare the bit after the first - and > before the second (one only before the second if the first does not > exist), with the version number tacked on the end. Coming in late on this discussion, I won't comment on the non-pkg_version related aspects of whatever this change was. However, sobomax and I have been working on some improvements to the ports infrastructure and pkg_version. Basically, sobomax proposed a way for installed packages to have a pointer back to their ports collection entry, and I made pkg_version take advantage of it for version number comparisons. This was intended to solve a couple of other problems, but I think it also gets rid of the one you folks have been discussing. asami is reviewing the changes. Cheers, Bruce. PS. You can follow this in the thread with headers that look like: Subject: Re: PROPOSAL: Use @comment PLIST variable to track where installed packages came from [Was: Enhancement of pkg_version's version comparison routine] --==_Exmh_-1438536511P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.3 (FreeBSD) Comment: Exmh version 2.2 06/23/2000 iD8DBQE55HPN2MoxcVugUsMRAhs4AKC8VNtyDhugO1P5+2lqq+DOfR1HtQCg3ThB LxRpSe0JDyPDyUYj3TNHZ1k= =3wi7 -----END PGP SIGNATURE----- --==_Exmh_-1438536511P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message