From owner-freebsd-sparc64@FreeBSD.ORG Fri Apr 15 02:39:23 2005 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2947D16A4CE for ; Fri, 15 Apr 2005 02:39:23 +0000 (GMT) Received: from rndsoft.co.kr (michelle.rndsoft.co.kr [211.32.202.209]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2855643D58 for ; Fri, 15 Apr 2005 02:39:22 +0000 (GMT) (envelope-from yongari@rndsoft.co.kr) Received: from yongari@rndsoft.co.kr(192.168.5.90) by MailFilter v1.05 with ESMTP Processed in 0.223933 secs; 15 Apr 2005 11:37:32 +0900 Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) by michelle.rndsoft.co.kr (8.13.1/8.13.1) with ESMTP id j3F2d2VP007984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 15 Apr 2005 11:39:02 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.1/8.13.1/Submit) id j3F2d2PP007983; Fri, 15 Apr 2005 11:39:02 +0900 (KST) (envelope-from yongari@rndsoft.co.kr) Date: Fri, 15 Apr 2005 11:39:02 +0900 From: Pyun YongHyeon To: John-Mark Gurney Message-ID: <20050415023902.GC7393@michelle.rndsoft.co.kr> References: <20050414092608.GB2855@michelle.rndsoft.co.kr> <20050414192749.GO56487@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050414192749.GO56487@funkthat.com> User-Agent: Mutt/1.4.2.1i cc: freebsd-sparc64@freebsd.org Subject: Re: em(4) patch X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: yongari@rndsoft.co.kr List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2005 02:39:23 -0000 On Thu, Apr 14, 2005 at 12:27:49PM -0700, John-Mark Gurney wrote: > > . always honor IFF_OACTIVE flag > > I made this mistake before myself.. Make sure you read the comment > describing OACTIVE.. you only set OACTIVE when the TX queue is full, > and clear it when it is not full.. not always set it when the board > is transmitting: > define IFF_OACTIVE 0x400 /* tx hardware queue is full */ > Do you mean IFF_OACTIVE should be set regardless of TX queue state when h/w is transmitting frames? Would you elaborate on an IFF_OACTIVE? > > . TX/RX descriptor alignment is 16 not PAGE_SIZE > > . TX/RX descriptor length should be multiple of 128 not 4096. > > You should probably use a define for this... > Yes. But AFAIK if_em_hw.h has no defined constants for these purposes. There are another hardcoded constants for processing 64bit IO BAR. I belive these constants should go pcireg.h. > > I have tested 82545GM chipset based card on Ultra60(SMP). VLAN and > > POLLING were not tested at all so it may have bugs. JUMBO frame support > > needs more coding and cleanups since sparc64 does not allow non-aligned > > memory access. So don't try to use JUMBO frame at this time. > > If you want to test em(4) on SMP with ofw_console you need additional > > patch. Alternatively you can use sc(4) or serial console. > > I'd like to hear success/failure. > > I think you should put back the while(!IFQ_DRV_IS_EMPTY, loop.. It > prevents an unnessary lock/unlock if both queues are empty... > Yes, you're right. > Also, I have work in progress to make non-aligned packets better... > I committed part of it as the m_copyup change... On a -current, you > should just be able to apply the following change: > http://perforce.freebsd.org/fileDiffView.cgi?FSPC=//depot/user/jmg/arm/src/sys/netinet/ip%5finput.c&REV=3&ACT=edit > This looks promising. Some miserable hardwares that use sf(4)/rl(4) driver could take advatnage of it. BTW what is IP_HDR_ALIGNED_P macro? > I'll try the patch when I get home... > Thanks. -- Regards, Pyun YongHyeon http://www.kr.freebsd.org/~yongari | yongari@freebsd.org