From nobody Mon Sep 12 18:03:45 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRDxV1Fw0z4bvBv for ; Mon, 12 Sep 2022 18:03:58 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRDxS70H3z3MnL for ; Mon, 12 Sep 2022 18:03:56 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-345528ceb87so110603127b3.11 for ; Mon, 12 Sep 2022 11:03:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=88g5qIhXdGmc6cUn5mb00yjzG0cluFJTOv72GAST2jg=; b=mYqGi7MKT8Npp2M7+/jH6g9FjmsGT45hl1wncyyZYdLIUMVTeAH8ZAphDjK9h/zEFj kJckkoz3I+UX23BXSMHc25vrvkUMA/MGdU/MFkGa8VC5+xI6V+9UQR7rYD3Ohk5f5xf0 ctWcC4jKCxBJ/uFyfHKJ8AsNWkM+ngNYVJBsI+4D2UiOO0Tt1LR/waf9L7anVz3yF4h6 drXqKZqC6ADAxQd8VUryqOu1qp6zHQZvJlV3Z03ehqi2cz7vDwdHMGTtsYIXBfbN1pKB nNyEqrLzRA3ELfgCDPhAu1HtJfJkKm8kkR1hgtkB/RSedF2rGxzRPBiO1oHoimZGPDjv 6eVQ== X-Gm-Message-State: ACgBeo3D+NxJ6XxQ6WgjnUeB+9rUyeHe1CRvuRIuP/7q6znkEP2CFs4b ut/8f8CZuzyFqzZrcjb8hpOpY5ktYHxDjXM3p65vGDUCkd95DA== X-Google-Smtp-Source: AA6agR5x4foq+bAC+QEfrOeWYbcRZ6B22aSlGpUMmAffQO0JA+yAi50T2EAYvFaYVD5ju4ycY0zFlRVEv0vfeYzIWmA= X-Received: by 2002:a81:4e97:0:b0:348:e5b8:8671 with SMTP id c145-20020a814e97000000b00348e5b88671mr12033561ywb.96.1663005835196; Mon, 12 Sep 2022 11:03:55 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202209081126.288BQwix012059@gitrepo.freebsd.org> In-Reply-To: From: Maxim Sobolev Date: Mon, 12 Sep 2022 20:03:45 +0200 Message-ID: Subject: Re: git: 6ad780caa262 - main - Generate termcap.small automatically. This eliminates the need to do synchronization by hand when termcap is updated. To: Gordon Bergling Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000110d6505e87eb8a4" X-Rspamd-Queue-Id: 4MRDxS70H3z3MnL X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sobomax@sippysoft.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=sobomax@sippysoft.com X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[sobomax@freebsd.org,sobomax@sippysoft.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.179:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.179:from]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FREEFALL_USER(0.00)[sobomax]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[sobomax@freebsd.org,sobomax@sippysoft.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --000000000000110d6505e87eb8a4 Content-Type: text/plain; charset="UTF-8" Hi Gordon, Thanks for letting me know. I will try to reproduce and fix the issue accordingly. -Max On Mon, Sep 12, 2022, 8:41 AM Gordon Bergling wrote: > Hi Maxim, > > On Thu, Sep 08, 2022 at 11:26:58AM +0000, Maxim Sobolev wrote: > > The branch main has been updated by sobomax: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=6ad780caa2622954bc0195039efd64cc1eef8174 > > > > commit 6ad780caa2622954bc0195039efd64cc1eef8174 > > Author: Maxim Sobolev > > AuthorDate: 2022-08-19 07:00:27 +0000 > > Commit: Maxim Sobolev > > CommitDate: 2022-09-08 11:22:37 +0000 > > > > Generate termcap.small automatically. This eliminates the > > need to do synchronization by hand when termcap is updated. > > > > Reviewed by: uqs, bapt, imp > > MFC after: 2 weeks > > Differential Revision: https://reviews.freebsd.org/D36333 > > this sadly breaks mergemaster and etcupdate over NFS mounted read-only > shares. > Took me a while to debug this, because the error messages of both commands > are bit misleading in such an error case. > > Could you make an entry about this in UPDATING? > > ===> share/termcap (installconfig) > installing DIRS CONFSDIR > install -N /boiler/nfs/src/etc -d -m 0755 -o root -g wheel > /var/db/etcupdate/etcupdate-KfDzboi/etc > set -e; set -o pipefail; (echo "# AUTOMATICALLY GENERATED FROM `basename > termcap`"; for tcname in SC cons25 cons25-m cons25-w cons25l1 cons25l1-m > cons25l1-w cons25l2 cons25l2-m cons25l7 cons25l7-m cons25r cons25r-m > cons25r-mv cons25r-v cons25w cons30 cons30-m cons30-w cons30l1 cons30l1-m > cons30l1-w cons30l2 cons30l2-m cons30l7 cons30l7-m cons30r cons30r-m > cons30r-mv cons30r-v cons43 cons43-m cons43-w cons43l1 cons43l1-m > cons43l1-w cons43l2 cons43l2-m cons43l7 cons43l7-m cons43r cons43r-m > cons43r-mv cons43r-v cons50 cons50-m cons50-w cons50l1 cons50l1-m > cons50l1-w cons50l2 cons50l2-m cons50l7 cons50l7-m cons50r cons50r-m > cons50r-mv cons50r-v cons60 cons60-m cons60-w cons60l1 cons60l1-m > cons60l1-w cons60l2 cons60l2-m cons60l7 cons60l7-m cons60r cons60r-m > cons60r-mv cons60r-v ecma[+]italics vt100 xterm xterm-basic xterm-clear > xterm-color xterm-new xterm-r6 xterm-r6-clear; do echo; awk > "/^${tcname}[:|]/{ f = 1; print; next } /^[^\t]/{ f = 0 } f" termcap; > done) > termcap.small > /bin/sh: cannot create termcap.small: Read-only file system > *** Error code 2 > > Stop. > make[4]: stopped in /boiler/nfs/src/share/termcap > *** Error code 1 > > Stop. > make[3]: stopped in /boiler/nfs/src/share > *** Error code 1 > > Stop. > make[2]: stopped in /boiler/nfs/src > *** Error code 1 > > [...] > > --Gordon > --000000000000110d6505e87eb8a4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Gordon,

Thanks for letting me know. I will try to reproduce and fix the issue a= ccordingly.

-Max

On M= on, Sep 12, 2022, 8:41 AM Gordon Bergling <gbe@freebsd.org> wrote:
https://cgit.FreeBSD.org/src/commit/?id=3D6ad780caa2622954bc0195039efd64= cc1eef8174
>
> commit 6ad780caa2622954bc0195039efd64cc1eef8174
> Author:=C2=A0 =C2=A0 =C2=A0Maxim Sobolev <sobomax@FreeBSD.org> > AuthorDate: 2022-08-19 07:00:27 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Maxim Sobolev <sobomax@FreeBSD.org> > CommitDate: 2022-09-08 11:22:37 +0000
>
>=C2=A0 =C2=A0 =C2=A0Generate termcap.small automatically. This eliminat= es the
>=C2=A0 =C2=A0 =C2=A0need to do synchronization by hand when termcap is = updated.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0Reviewed by:=C2=A0 =C2=A0 uqs, bapt, imp
>=C2=A0 =C2=A0 =C2=A0MFC after:=C2=A0 =C2=A0 =C2=A0 2 weeks
>=C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 ht= tps://reviews.freebsd.org/D36333

this sadly breaks mergemaster and etcupdate over NFS mounted read-only shar= es.
Took me a while to debug this, because the error messages of both commands =
are bit misleading in such an error case.

Could you make an entry about this in UPDATING?

=3D=3D=3D> share/termcap (installconfig)
installing DIRS CONFSDIR
install -N /boiler/nfs/src/etc=C2=A0 -d -m 0755 -o root=C2=A0 -g wheel=C2= =A0 /var/db/etcupdate/etcupdate-KfDzboi/etc
set -e; set -o pipefail;=C2=A0 (echo "# AUTOMATICALLY GENERATED FROM `= basename termcap`";=C2=A0 for tcname in SC cons25 cons25-m cons25-w co= ns25l1 cons25l1-m=C2=A0 cons25l1-w cons25l2 cons25l2-m cons25l7 cons25l7-m = cons25r cons25r-m=C2=A0 cons25r-mv cons25r-v cons25w cons30 cons30-m cons30= -w cons30l1 cons30l1-m=C2=A0 cons30l1-w cons30l2 cons30l2-m cons30l7 cons30= l7-m cons30r cons30r-m=C2=A0 cons30r-mv cons30r-v cons43 cons43-m cons43-w = cons43l1 cons43l1-m=C2=A0 cons43l1-w cons43l2 cons43l2-m cons43l7 cons43l7-= m cons43r cons43r-m=C2=A0 cons43r-mv cons43r-v cons50 cons50-m cons50-w con= s50l1 cons50l1-m=C2=A0 cons50l1-w cons50l2 cons50l2-m cons50l7 cons50l7-m c= ons50r cons50r-m=C2=A0 cons50r-mv cons50r-v cons60 cons60-m cons60-w cons60= l1 cons60l1-m=C2=A0 cons60l1-w cons60l2 cons60l2-m cons60l7 cons60l7-m cons= 60r cons60r-m=C2=A0 cons60r-mv cons60r-v ecma[+]italics vt100 xterm xterm-b= asic xterm-clear=C2=A0 xterm-color xterm-new xterm-r6 xterm-r6-clear;=C2=A0= do=C2=A0 echo; awk "/^${tcname}[:|]/{ f =3D 1; print; next } /^[^\t]/= { f =3D 0 } f" termcap;=C2=A0 done) > termcap.small
/bin/sh: cannot create termcap.small: Read-only file system
*** Error code 2

Stop.
make[4]: stopped in /boiler/nfs/src/share/termcap
*** Error code 1

Stop.
make[3]: stopped in /boiler/nfs/src/share
*** Error code 1

Stop.
make[2]: stopped in /boiler/nfs/src
*** Error code 1

[...]

--Gordon
--000000000000110d6505e87eb8a4--