From owner-svn-src-all@freebsd.org  Mon Feb 26 20:31:17 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 115EEF114E8;
 Mon, 26 Feb 2018 20:31:17 +0000 (UTC)
 (envelope-from pkelsey@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BB57087DED;
 Mon, 26 Feb 2018 20:31:16 +0000 (UTC)
 (envelope-from pkelsey@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B610B20494;
 Mon, 26 Feb 2018 20:31:16 +0000 (UTC)
 (envelope-from pkelsey@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w1QKVGcZ062586;
 Mon, 26 Feb 2018 20:31:16 GMT (envelope-from pkelsey@FreeBSD.org)
Received: (from pkelsey@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w1QKVGrS062585;
 Mon, 26 Feb 2018 20:31:16 GMT (envelope-from pkelsey@FreeBSD.org)
Message-Id: <201802262031.w1QKVGrS062585@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: pkelsey set sender to
 pkelsey@FreeBSD.org using -f
From: Patrick Kelsey <pkelsey@FreeBSD.org>
Date: Mon, 26 Feb 2018 20:31:16 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r330035 - head/sys/netinet
X-SVN-Group: head
X-SVN-Commit-Author: pkelsey
X-SVN-Commit-Paths: head/sys/netinet
X-SVN-Commit-Revision: 330035
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Feb 2018 20:31:17 -0000

Author: pkelsey
Date: Mon Feb 26 20:31:16 2018
New Revision: 330035
URL: https://svnweb.freebsd.org/changeset/base/330035

Log:
  Ensure signed comparison to avoid false trip of assert during VNET teardown.
  
  Reported by:	lwhsu
  MFC after:	1 month

Modified:
  head/sys/netinet/tcp_fastopen.c

Modified: head/sys/netinet/tcp_fastopen.c
==============================================================================
--- head/sys/netinet/tcp_fastopen.c	Mon Feb 26 19:27:59 2018	(r330034)
+++ head/sys/netinet/tcp_fastopen.c	Mon Feb 26 20:31:16 2018	(r330035)
@@ -1101,7 +1101,7 @@ tcp_fastopen_ccache_bucket_trim(struct tcp_fastopen_cc
 		if (entries > limit)
 			tcp_fastopen_ccache_entry_drop(cce, ccb);
 	}
-	KASSERT(ccb->ccb_num_entries <= limit,
+	KASSERT(ccb->ccb_num_entries <= (int)limit,
 	    ("%s: ccb->ccb_num_entries %d exceeds limit %d", __func__,
 		ccb->ccb_num_entries, limit));
 	if (limit == 0) {