From owner-cvs-ports@FreeBSD.ORG  Tue Aug 23 21:03:33 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 626FF106566B;
	Tue, 23 Aug 2011 21:03:33 +0000 (UTC)
	(envelope-from glarkin@FreeBSD.org)
Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 341DF8FC1C;
	Tue, 23 Aug 2011 21:03:33 +0000 (UTC)
Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235]
	helo=cube.entropy.prv)
	by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD))
	(envelope-from <glarkin@FreeBSD.org>)
	id 1QvxcV-0008Ml-BX; Tue, 23 Aug 2011 16:30:57 -0400
Received: from v104.entropy.prv (v104.entropy.prv [192.168.1.104])
	by cube.entropy.prv (Postfix) with ESMTP
	id 1F22251DA00B; Tue, 23 Aug 2011 16:30:57 -0400 (EDT)
Message-ID: <4E540E00.1030609@FreeBSD.org>
Date: Tue, 23 Aug 2011 16:30:56 -0400
From: Greg Larkin <glarkin@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
	rv:1.9.2.20) Gecko/20110804 Lightning/1.0b2 Thunderbird/3.1.12
MIME-Version: 1.0
To: Doug Barton <dougb@FreeBSD.org>
References: <201108232003.p7NK3ZQx066601@repoman.freebsd.org>
	<4E5409AE.9050400@FreeBSD.org>
In-Reply-To: <4E5409AE.9050400@FreeBSD.org>
X-Enigmail-Version: 1.1.1
OpenPGP: id=1C940290
X-SA-Exim-Connect-IP: 68.189.245.235
X-SA-Exim-Mail-From: glarkin@FreeBSD.org
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	mail1.sourcehosting.net
X-Spam-Level: ***
X-Spam-Status: No, score=3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL,
	RCVD_IN_RP_RNBL, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC,
	TVD_RCVD_IP autolearn=no version=3.3.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SA-Exim-Version: 4.2
X-SA-Exim-Scanned: Yes (on mail1.sourcehosting.net)
Cc: cvs-ports@FreeBSD.org, C-S <c-s@c-s.li>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/hiawatha Makefile ports/www/hiawatha/files
 hiawatha.in php-fcgi.in pkg-message.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: glarkin@FreeBSD.org
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2011 21:03:33 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/23/11 4:12 PM, Doug Barton wrote:
> The rc.d script looks good, thanks!
> 
> The only thing I would do differently is instead of having 2 separate lines:
> 
> : ${hiawatha_pidfile="/var/run/hiawatha.pid"}
> pidfile=${hiawatha_pidfile}
> 
> Do it like this:
> 
> pidfile=${hiawatha_pidfile="/var/run/hiawatha.pid"}
> 
> But that's really a micro-optimization.
> 
> 
> Thanks again,
> 
> Doug
> 

Nice job, Carlo!  We can add that change on the next hiawatha update.

Cheers,
Greg
- -- 
Greg Larkin

http://www.FreeBSD.org/           - The Power To Serve
http://www.sourcehosting.net/     - Ready. Set. Code.
http://twitter.com/cpucycle/      - Follow you, follow me
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5UDgAACgkQ0sRouByUApDUnwCeLlA3mrm+8bHB7f8tqSkmOZiP
lskAn0An2pU2ahPY4joFDWi4c68vINrd
=RrI1
-----END PGP SIGNATURE-----