From owner-freebsd-gnome@freebsd.org Mon Oct 19 00:39:15 2020 Return-Path: Delivered-To: freebsd-gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6A8BF44045D for ; Mon, 19 Oct 2020 00:39:15 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CDyYt36Kdz3dS7 for ; Mon, 19 Oct 2020 00:39:14 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: by mail-oi1-x232.google.com with SMTP id q136so10634550oic.8 for ; Sun, 18 Oct 2020 17:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m5yQPyRWkZrPoW9NXOGnKfQ17XuV2ZqmZ4izHPH7rQo=; b=ssQWfydUGw892OCY9cybFh5hseXS1G/UbzKU24nh1IaZfIuUHkqxlVKiM+9KD0EBtB 8l6x4IbT4NWiuq81Yf7YbruPyLjln/xiAh5PrS9Sk3V+WZZNao4httmDpkdmBRZa+bkk VMIdtPX4jADkPw6w6qM92fCXenm4ag7+C9Ht4I7po8WTQSw03nv8pORMk/9KGQV32aUd 6GHZeiWHl/BmrbQUROc7NsyzXjvMoIn/hpih1eqRCEq7TT+Db/e/Vf5Iu2Boml3gtl7X rozo51UFic8h3x7xUDFERccyKxN6NL+OOSdHgqrY6/6UAfKIGsUqC8GfZaL51Wx6Qn2J tvrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m5yQPyRWkZrPoW9NXOGnKfQ17XuV2ZqmZ4izHPH7rQo=; b=ie7ShAQCoe2/ZfhKqCE6tdqke+JSEsp6DT3aOciDXsLTWeT0L/UI7v0o1BifaSN3YN fpZZSjK6aYUQTtPyFHDhpb4/44iDfHvs2leXP5MYv+xMq4JeT5kLuIWMKqVOca3/QOOi sGONMOWoJ4nktpQL6XJGOWxgDN3vaogzZN2rZX7AMeRwEGjXnhnI+PtIWC/y76ccmEBk CWYD9Yi4U92/CBeqgRA8hm6DPuR0aFeXsGWSVXB3+fdSHjZk2Wetrd4QfVv63zeAODsh oHZhEoGI/P/4iZGPwdAt08CeEuh4TQQf3srtVnY5MuoCrrFeQ2SqvGgcmDZsDxiOvepF bFhQ== X-Gm-Message-State: AOAM533H3sZw5UXFA7LFb1GB6IHvnb8jaxURXno/nBO0PeBWm0l7uh3P Es9+6X9IepvedWHH0PKmKy+Z12gIEJP8bzr44u+pfyDwMrvpEw== X-Google-Smtp-Source: ABdhPJzWb31BHDW9tHX6dZiqOPwj3hWmcl5GDxqZQaO71IF/Xc+MS7Wh3riRtPjHiUUz8bG8tYjUJT5GJoITzMpLwAw= X-Received: by 2002:aca:2b05:: with SMTP id i5mr2150545oik.57.1603067953099; Sun, 18 Oct 2020 17:39:13 -0700 (PDT) MIME-Version: 1.0 References: <20201016234218.GA69749@in-addr.com> In-Reply-To: From: Kevin Oberman Date: Sun, 18 Oct 2020 17:38:56 -0700 Message-ID: Subject: Re: curl update to 7.73.0 breaks ABI? To: Christian Weisgerber Cc: "freebsd-gnome@FreeBSD.org" X-Rspamd-Queue-Id: 4CDyYt36Kdz3dS7 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ssQWfydU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of kob6558@gmail.com designates 2607:f8b0:4864:20::232 as permitted sender) smtp.mailfrom=kob6558@gmail.com X-Spamd-Result: default: False [-2.33 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.59)[-0.588]; FORGED_SENDER(0.30)[rkoberman@gmail.com,kob6558@gmail.com]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[rkoberman@gmail.com,kob6558@gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.07)[-1.070]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.971]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-gnome@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::232:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-gnome] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 00:39:15 -0000 On Sun, Oct 18, 2020 at 2:05 PM Christian Weisgerber wrote: > On 2020-10-16, Gary Palmer wrote: > > > Check you have "COOKIES" and "ALTSVC" (I think) checked in the curl > > options. I had cookies disabled for some reason in one of my builds and > > it resulted in Curl_get_line not being generated > > Since 7.73.0, all of lib/curl_get_line.c is behind this: > > #if !defined(CURL_DISABLE_COOKIES) && !defined(CURL_DISABLE_ALTSVC) > > -- > Christian "naddy" Weisgerber naddy@mips.inka.de > Yes, but ALTSVC is set by default (and so is COOKIES) in the port and it is still not built. (I had only ALTSVC, not COOKIES.) I have now built with COOKIES and it works. Also tried COOKIES without ALTSVC and it also worked. Not sure why the choice in the presentation of the #if. I'd demornganize it for clarity. #if defined(CURL_DISABLE_COOKIES) || defined(CURL_DISABLE_ALTSVC) Still, it should be built and I don't understand why it's not! Does Makefile syntax require parens around the full expression? That would explain it. -- Kevin Oberman, Part time kid herder and retired Network Engineer E-mail: rkoberman@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683