From owner-freebsd-net@FreeBSD.ORG Tue Jun 9 08:05:37 2009 Return-Path: Delivered-To: net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E54A5106564A; Tue, 9 Jun 2009 08:05:37 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (unknown [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 62BC68FC13; Tue, 9 Jun 2009 08:05:37 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from delta.allbsd.org (p3185-ipbf514funabasi.chiba.ocn.ne.jp [123.225.96.185]) (authenticated bits=128) by mail.allbsd.org (8.14.3/8.14.3) with ESMTP id n5984Pfr041789; Tue, 9 Jun 2009 17:04:36 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (alph.allbsd.org [192.168.0.10]) (authenticated bits=0) by delta.allbsd.org (8.13.4/8.13.4) with ESMTP id n5983pbt072769; Tue, 9 Jun 2009 17:03:53 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Tue, 09 Jun 2009 17:03:28 +0900 (JST) Message-Id: <20090609.170328.129820575.hrs@allbsd.org> To: bzeeb-lists@lists.zabbadoz.net From: Hiroki Sato In-Reply-To: <20090609074144.O22887@maildrop.int.zabbadoz.net> References: <4A2E0D12.40101@delphij.net> <20090609074144.O22887@maildrop.int.zabbadoz.net> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.2.51 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Tue_Jun__9_17_03_28_2009_143)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (mail.allbsd.org [133.31.130.32]); Tue, 09 Jun 2009 17:04:36 +0900 (JST) Cc: d@delphij.net, current@FreeBSD.org, hrs@FreeBSD.org, net@FreeBSD.org, danny@cs.huji.ac.il, rea-fbsd@codelabs.ru Subject: Re: [head tinderbox] failure on sparc64/sparc64 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 08:05:38 -0000 ----Security_Multipart(Tue_Jun__9_17_03_28_2009_143)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Bjoern A. Zeeb" wrote in <20090609074144.O22887@maildrop.int.zabbadoz.net>: bz> On Tue, 9 Jun 2009, Xin LI wrote: bz> bz> > Danny Braniss wrote: bz> >>> Xin, good day. bz> >>> bz> >>> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: bz> >>>> The attached patch should fix this, any objections? bz> >>> Yes, you missed negation operator in the copyin check. The issue bz> >>> was already fixed by hrs@ two hours ago: bz> >>> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 bz> >> sorry to barge in, but: bz> >> if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) bz> >> is not clear, bz> >> if ((options & ~GIF_FULLOPTS) == 0) bz> >> seems to be less offuscated or I'm missing something? bz> > bz> > Yes this looks like the usually used idiom (perhaps more efficient bz> > anyway)... I just kept the style consistent with the old code. bz> > Hiroki-san, could you have a look at this and consider if we should bz> > use bz> > this idiom? bz> bz> Also see the mail I had sent in reply to the commit message yesterday. Sorry, I overlooked some of the messages I received. Yes, the logic was reversed and fixed now, but your patch including style fix looks better to me. I will commit it. Thank you for your review! -- Hiroki ----Security_Multipart(Tue_Jun__9_17_03_28_2009_143)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkouF1AACgkQTyzT2CeTzy1lcACfc5RgQgb7oLMdGSwbMjob4W5M pLkAnRLDVDaLMfpf5e8I2WHV/SeM02Yh =BQGc -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Jun__9_17_03_28_2009_143)----