From owner-svn-src-all@freebsd.org Sun Nov 11 01:54:44 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D190112417A for ; Sun, 11 Nov 2018 01:54:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it1-x133.google.com (mail-it1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6964E86FCE for ; Sun, 11 Nov 2018 01:54:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it1-x133.google.com with SMTP id v11so8762219itj.0 for ; Sat, 10 Nov 2018 17:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ncpCrFoz0B0kOHx4sGUM25TpXD4btg3ccQawQtBRDQw=; b=RbihWSqjMvF4dtznEMLWyWXACir5WAhiwEEW7zIKQxNpvNN9R2wWAoOd+Co8mYSh+I euEKH3earMZiZKgGZn0i6aiyvqHW8WvP6kRYZ9D723kHhg31HQEfhzgKyl42loTvbLZf I3yEcoxciH5F/er0IRcshNxiK/AitJzHTdshgeQlWHqi5laT0Fv6WH5xvJnDIn27FiEr IfB3UiJJTENf6feWj/fwg3Ux3ykOE3wC2DWeTx9KjdBJrx2JhcIgLeK0t7qtKDjMpAgf Pen/jF5ipKfFRX/S9/DOHCda3UgPbyUcOH/7ikk1SZhcGYm5v9B/WZvRJVDpV1XwvoTq KQOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ncpCrFoz0B0kOHx4sGUM25TpXD4btg3ccQawQtBRDQw=; b=Nw2O4MvLAH2ZlXGC+tSpOJicDoL92xu4OiGhb2VwfToiZEW+4PVpDpkX5SYstDAXgh I6Bwx5LI3PwDJn3Ro9B/v3Egh/wFnTGb+8NvboLIbtTA0nz9oBa3SCv5HMFftFaFVO3/ K5NT7c2jw/f9c9E6LoaoNbJHLiNR/FJJeyUvHtV3EdHLl/FU39PIbCHfuiJ/zwWY/K9L buhsKvXdvsLAB60I1VQFG03NLYpTN4nvFdnyODBeIkpRq4WXAGnyurVSZeOX2TYWD1Zl lVzdVQz6+eLux9ZXbPR3quHoHcnvZ4SLLmalHa7gosdySWiZ8fc36f66V/PvO9Khe44G kwtg== X-Gm-Message-State: AGRZ1gIeOqTZtls0BRDuhh27YzPLA0zQ80l54foGeLdhZ6/Bj4pLDGz7 AS70P0p3rA3UcRUnRPCNiyy0GtFMC8Prs8MBu1KAHQ== X-Google-Smtp-Source: AJdET5ci5bLNHGtv5PGDlyb7YggKOJNmDgKHmFJ4J0YoKgSAz8dppYdQ+olR+8ogpWH5HnLN5x06qn32ON9EBTI6phM= X-Received: by 2002:a24:eb0b:: with SMTP id h11-v6mr7207620itj.47.1541901282389; Sat, 10 Nov 2018 17:54:42 -0800 (PST) MIME-Version: 1.0 References: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> <20181111013816.GA2880@spy> In-Reply-To: <20181111013816.GA2880@spy> From: Warner Losh Date: Sat, 10 Nov 2018 18:54:30 -0700 Message-ID: Subject: Re: svn commit: r340326 - head To: Mark Johnston Cc: "Rodney W. Grimes" , Ben Woods , Ben Woods , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 6964E86FCE X-Spamd-Result: default: False [-3.93 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.941,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[3.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.98)[ipnet: 2607:f8b0::/32(-2.88), asn: 15169(-1.92), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 01:54:44 -0000 On Sat, Nov 10, 2018, 6:38 PM Mark Johnston On Sat, Nov 10, 2018 at 05:07:38PM -0800, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > > If your going to bother with a differential, and invite people to > > > > it you should give them at least 24 hours, and preferably 72 hours > > > > to respond to the new review. Reviews that last < 4 hours are not > > > > code reviews. > > > > > > > > -- > > > > Rod Grimes > > > > rgrimes@freebsd.org > > > > > > > Hi Rod, > > > > > > Sorry. The main reason I submitted the code review is because I do not > have > > > my src commit bit, so needed to seek approval to commit. > > > > All the more reason for it to wait until the people you *invited* to > > the review to have a chance to respond. > > > > I do not believe an "accept" in a review is an "approve to commit > > beyond your normal scope". > > I think that's being pedantic. UPDATING is an English text file, no > special qualification is needed to add an entry. Ben waited for two > months before committing r340318; I'm sure he appreciates the need to > give reviewers time to review anything controversial. > > > Was cem aware that he was "approving a non src committer to commit > > this change to the src tree" as your review has no mention that you > > are seeking src bit approval to commit there. > > I doubt he worried too much about the distinction. If a committer > clicks "accept," it means, "the change looks good to me." Does it > matter how it gets committed, at least in this trivial case? > > > > I felt the need to commit the UPDATING entry was time sensitive, given > the > > > change it was notifying users of had already been committed. > > That makes perfect sense to me. > As the nominal owner of UPDATING, this is exactly what I invented for: to update users of time critical information. If there are improvements to the language, they can be made. Churn causes very little trouble for this file. Warner >