From owner-freebsd-hackers@freebsd.org Fri Sep 13 06:19:37 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD874E7184 for ; Fri, 13 Sep 2019 06:19:37 +0000 (UTC) (envelope-from luthramihir708@gmail.com) Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46V5883YKnz4CnK for ; Fri, 13 Sep 2019 06:19:36 +0000 (UTC) (envelope-from luthramihir708@gmail.com) Received: by mail-vk1-xa29.google.com with SMTP id t136so5694275vkt.9 for ; Thu, 12 Sep 2019 23:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9tclA750BDdvSOqHlSfhmp1VoLi8QazyWnfvlIhl1wY=; b=iM0KP17Q3BheQtwPy0YusLeu4+UhY/efWD8VKcRntCB2KoC3w997GoGcLqIJhn61DR TQl2nC6krQ7DMepZhot9kVpb5dzqWGmNXNgAd5bpNKoKj6toJ95zREk5+mO5bIW1gKB5 9CrHum6sCVvGrenWPXmM4/pTYbLzdz8BRv6SB1mrfMyV11dyL7dzPcQinHg/HQNoqH87 QzJu18bfRw36sZssD5kevWFROFPpjkgB3sxGwhD6VSJ52ApiMn1LFoCxngP5ruutv8iE JfKtHgerRrPt3kHVT2BFO86A/5tS0Sd4aHotq+CqDnafVOar+dotQUs2ag/W6HSvZ7Dz fdrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9tclA750BDdvSOqHlSfhmp1VoLi8QazyWnfvlIhl1wY=; b=XhBlSJBarukGK73DiZ2qxppa3UGoYkKgUjQRUGlZOBHjfqDWbpUMONZCd3VT1KhkZn 24ueERWQCH4eBkvpHe3F3lRMIjieIPxGfhZKhzF2ceNxleUeqruoJa20MOnn4VOOr7vr rn2uRqFkhjDW6pcij5UwEAI8TT0q125ijzfGf2xQB1OwLZkBIjK4lZqp6XAest/h1QgJ TMmKbs+WIjKBv9WcS1zf7/r9TKC/kTgRL6Ch5qzj6XKUzki7y74iEZmV4e7DqlgR+gqs 633TOnu5BCrhkZ5AZa4RA2rgPBMdCbkYMFh6XtD8fnL9p1xilOj2jCKDMJPmRdsBFiHh 7i9w== X-Gm-Message-State: APjAAAW8I6gEuHSxZWg/WdIQ+sXyXu6PZapfg38f3WdJ5x/a5zWBP9v0 CnBzZj30zUHoayK2jQUXev+jhewQN3vipJqMERgeUzQ+C1E= X-Google-Smtp-Source: APXvYqwbHGLOiOF+lmyW+vPa+A1nEBR0PbehsUCBKrCmTJWGpGf4GWkTeJ5+G0Gp3BRNqTeU4PIF0LS9Ci/BR8hwpiI= X-Received: by 2002:ac5:c4e9:: with SMTP id b9mr11713125vkl.83.1568355574786; Thu, 12 Sep 2019 23:19:34 -0700 (PDT) MIME-Version: 1.0 From: Mihir Luthra Date: Fri, 13 Sep 2019 11:49:23 +0530 Message-ID: Subject: correct ways to get code reviewed To: freebsd-hackers@freebsd.org X-Rspamd-Queue-Id: 46V5883YKnz4CnK X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=iM0KP17Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of luthramihir708@gmail.com designates 2607:f8b0:4864:20::a29 as permitted sender) smtp.mailfrom=luthramihir708@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-9.58), ipnet: 2607:f8b0::/32(-2.71), asn: 15169(-2.24), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[9.2.a.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 06:19:37 -0000 Hi everyone, I am a new contributor to FreeBSD projects. Recently I have started making changes in the source code by working on project ipv6 userland cleanup [1]. I did post one patch to phabrictor which got reviewed as well. I had some queries in my mind on which I wanted some advice. 1) Should I post another patch only after the first one has been approved or is it better to keep posting patches irrespective of review status of the first? 2) Should I ask commiters for review individually or should I post the link on the mailing lists? Or maybe should I simply wait for the patch to get reviewed without informing anyone? 3) If the patch gets approved, do I need to submit a pul request on github or is their some different procedure? [1] https://wiki.freebsd.org/SummerOfCodeIdeas#IPv6_Userland_Cleanup Thanks, Mihir