From owner-cvs-all@FreeBSD.ORG Mon Jan 19 10:51:35 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 585D716A4CE; Mon, 19 Jan 2004 10:51:35 -0800 (PST) Received: from plouf.absolight.net (plouf.absolight.net [212.43.217.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB8FC43D1D; Mon, 19 Jan 2004 10:51:33 -0800 (PST) (envelope-from mat@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by plouf.absolight.net (Postfix) with ESMTP id 934A54ADBB1; Mon, 19 Jan 2004 19:51:32 +0100 (CET) Received: from pouet.in.mat.cc (pouet.in.mat.cc [212.43.217.126]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by plouf.absolight.net (Postfix) with ESMTP id 7B2524ADA29; Mon, 19 Jan 2004 19:51:31 +0100 (CET) Date: Mon, 19 Jan 2004 19:51:29 +0100 From: Mathieu Arnold To: obrien@FreeBSD.org Message-ID: <2549890.1074541889@pouet.in.mat.cc> In-Reply-To: <20040119184544.GB6433@dragon.nuxi.com> References: <200401191544.i0JFib85052132@repoman.freebsd.org> <20040119163258.GB4722@dragon.nuxi.com> <359167705.1074533881@andromede.reaumur.absolight.net> <20040119184544.GB6433@dragon.nuxi.com> X-Mailer: Mulberry/3.1.0 (Win32) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Virus-Scanned: by amavisd 0.1 cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2004 18:51:35 -0000 +-Le 19/01/2004 10:45 -0800, David O'Brien =E9crivait : | On Mon, Jan 19, 2004 at 05:38:01PM +0100, Mathieu Arnold wrote: |> +-le 19/01/2004 08:32 -0800, David O'Brien ?crivait : |> | On Mon, Jan 19, 2004 at 07:44:37AM -0800, Mathieu Arnold wrote: |> |> mat 2004/01/19 07:44:37 PST |> |>=20 |> |> FreeBSD ports repository |> |>=20 |> |> Modified files: |> |> mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist=20 |> |> Log: |> |> Update to 2.62 |> |> Have the least thing possible between bsd.port.pre.mk and post.mk |> |=20 |> | Please back this out. It is hard to read and find the dependencies. |> | The Porter's handbook clearly documents where w/in a port's Makefile |> | {BUILD,RUN}_DEPENDS belong in the Makefile. |>=20 |> Do you really mean that every perl port that does this should be changed |> ? it's the first time someone tells me so. |=20 | Well, I guess that opens up a discussion then. I don't use many "p5" | ports, but I certainly do use SpamAssassin daily. So I hadn't noticed | that they go against the Porters Handbook and 'portlint'. It is | important to keep things all in the proper section so a user like me can | know what dependencies there are. Often I install dependencies from a | precompiled package before I add local patches to the "leaf" port that I | ultimately want installed. Well, portlint will complain if you do things badly, but it won't complain when you do just that. perl ports have been done this way for ages, I mean, the normal dependencies at the right place, and the dependencies depending on perl version at the end. I was told it was the right way to do it when I began updating ports, so I though it was the right way. --=20 Mathieu Arnold