Date: Mon, 31 Dec 2012 15:39:00 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Jason Helfman <jgh@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r309705 - in head/irc: . dxirc Message-ID: <20121231143900.GG83139@ithaqua.etoilebsd.net> In-Reply-To: <8701822.2t1vcGT59x@mocha.verizon.net> References: <201212310346.qBV3kR0W049479@svn.freebsd.org> <8701822.2t1vcGT59x@mocha.verizon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--PyMzGVE0NRonI6bs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Dec 31, 2012 at 09:06:26AM -0500, Jason E. Hale wrote:
> On Monday, December 31, 2012 03:46:27 Jason Helfman wrote:
> > Added: head/irc/dxirc/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> > --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> > +++ head/irc/dxirc/Makefile Mon Dec 31 03:46:26 2012 (r30970=
5)
> > @@ -0,0 +1,80 @@
> >
> > +LICENSE=3D GPLv3
> > +LICENSE_FILE=3D ${WRKSRC}/COPYING
>=20
> LICENSE_FILE should be dropped for standard license
>=20
> > +LIB_DEPENDS=3D FOX-1:${PORTSDIR}/x11-toolkits/fox16
>=20
> The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI=
=20
> version number.
and even if it was in that case it shouldn't be removed because in here we =
only
want fox16 and not fox17 for example.
>=20
> > +OPTIONS_DEFINE=3D NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY
> > +OPTIONS_DEFAULT=3D NLS TRAY IPV6 SSL LUA
>=20
> NLS doesn't need to be in OPTIONS_DEFAULT...it is already default. Might=
as=20
> well add DOCS to OPTIONS_DEFINE too.
IPV6 and NLS does not need the framework does it by default
>=20
> > Added: head/irc/dxirc/pkg-plist
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> > =3D=3D --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> > +++ head/irc/dxirc/pkg-plist Mon Dec 31 03:46:26 2012 (r309705)
> > @@ -0,0 +1,297 @@
> > +%%DATADIR%%/COPYING
>=20
> Since LICENSE is already defined, the installation of an additional licen=
se=20
> file should be squashed.
>=20
> > +@dirrm share/applications
>=20
> This should be a @dirrmtry since it is a shared directory.
>=20
> --=20
> Jason E. Hale - jhale@
> FreeBSD Ports Committer
> KDE/FreeBSD Team
--PyMzGVE0NRonI6bs
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlDho4QACgkQ8kTtMUmk6EwI9wCfdaogdKHqxuekBXCge4iVrDCQ
IhIAn0OF9gDB8SwMk4M2AxGMTyYYeeJT
=9eyE
-----END PGP SIGNATURE-----
--PyMzGVE0NRonI6bs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121231143900.GG83139>