From owner-cvs-all Tue May 28 6:50:49 2002 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id E47F537B404; Tue, 28 May 2002 06:50:43 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g4SCjXnw000598; Tue, 28 May 2002 14:45:33 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Marcel Moolenaar Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf NOTES files options src/sys/geom geom_gpt.c geom_mbr.c src/sys/sys gpt.h In-Reply-To: Your message of "Tue, 28 May 2002 02:04:49 PDT." <200205280904.g4S94nu58457@freefall.freebsd.org> Date: Tue, 28 May 2002 14:45:33 +0200 Message-ID: <597.1022589933@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200205280904.g4S94nu58457@freefall.freebsd.org>, Marcel Moolenaar w rites: >marcel 2002/05/28 02:04:48 PDT > > Add support to GEOM for GUID Partition Tables (GPTs). The support > is currently conditional on both the GEOM and GEOM_GPT options to > avoid getting GPT by default and having the MBR and GPT classes > clash. Congratulations! You just became the first "non-author" GEOM developer :-) I can't read your code right now, my CVS is not up to date, I may send you comments later on. > The correct behaviour of the MBR class would be to back-off (reject) > a MBR if it's a Protective MBR (a MBR with a single partition of type > 0xEE that spans the whole disk (as far as the MBR is concerned). > The correct behaviour if the GPT class would be to back-off (reject) > a GPT if there's a MBR that's not a Protective MBR. I have no really good ideas for how to resolve the various and conflicting methods claims to the same disk-image. I guess in the end it will come down to a number of more or less crude heuristics in the relevant methods. There is as such no harm in having both an MBR and a GPT on the same device, as long as people do not use the wrong one. It would be really beneficial if you can help me with producing a XML disk image to put in the regression tests. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message