From owner-cvs-all@FreeBSD.ORG  Tue Aug 23 20:13:02 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id 7381210656AD;
	Tue, 23 Aug 2011 20:13:02 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 9A99E15FEB4;
	Tue, 23 Aug 2011 20:12:30 +0000 (UTC)
Message-ID: <4E5409AE.9050400@FreeBSD.org>
Date: Tue, 23 Aug 2011 13:12:30 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:6.0) Gecko/20110819 Thunderbird/6.0
MIME-Version: 1.0
To: Greg Larkin <glarkin@FreeBSD.org>
References: <201108232003.p7NK3ZQx066601@repoman.freebsd.org>
In-Reply-To: <201108232003.p7NK3ZQx066601@repoman.freebsd.org>
X-Enigmail-Version: undefined
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, C-S <c-s@c-s.li>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/hiawatha Makefile ports/www/hiawatha/files
 hiawatha.in php-fcgi.in pkg-message.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2011 20:13:02 -0000

The rc.d script looks good, thanks!

The only thing I would do differently is instead of having 2 separate lines:

: ${hiawatha_pidfile="/var/run/hiawatha.pid"}
pidfile=${hiawatha_pidfile}

Do it like this:

pidfile=${hiawatha_pidfile="/var/run/hiawatha.pid"}

But that's really a micro-optimization.


Thanks again,

Doug


On 08/23/2011 13:03, Greg Larkin wrote:
> glarkin     2011-08-23 20:03:35 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/hiawatha         Makefile 
>     www/hiawatha/files   hiawatha.in pkg-message.in 
>   Added files:
>     www/hiawatha/files   php-fcgi.in 
>   Log:
>   - Added rc.d file for php-fcgi (Hiawatha FastCGI daemon)
>   - Cleanups in hiawatha rc.d file
>   - Bumped PORTREVISION
>   
>   PR:             ports/158944  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158944
>   Submitted by:   C-S <c-s@c-s.li> (maintainer)
>   
>   Revision  Changes    Path
>   1.32      +2 -1      ports/www/hiawatha/Makefile
>   1.3       +19 -7     ports/www/hiawatha/files/hiawatha.in
>   1.1       +36 -0     ports/www/hiawatha/files/php-fcgi.in (new)
>   1.5       +3 -0      ports/www/hiawatha/files/pkg-message.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/Makefile.diff?&r1=1.31&r2=1.32&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/hiawatha.in.diff?&r1=1.2&r2=1.3&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/php-fcgi.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/hiawatha/files/pkg-message.in.diff?&r1=1.4&r2=1.5&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/